Page MenuHomePhorge

Make the resend button a ToolButton
ClosedPublic

Authored by nannanko on Jul 13 2024, 6:36 AM.

Details

Summary

"Unable to send" indicator is not obvious that it is clickable, This revision make it a ToolButton.

Type: fix

Test Plan

Make a local echo event.
Verify that the button appears with a border when the mouse is hovered.
Verify that the message is resent when the button is clicked.

Diff Detail

Repository
rK kazv
Branch
resend-button
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 199
Build 387: GitLab CI for kazv
Build 386: arc lint + arc unit

Event Timeline

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 13 2024, 6:52 AM
Harbormaster failed remote builds in B172: Diff 291!

Fix tests for resent button

tusooa requested changes to this revision.Jul 13 2024, 8:04 AM

You chose the wrong base in the second version.

This revision now requires changes to proceed.Jul 13 2024, 8:04 AM
src/contents/ui/Bubble.qml
194

Which means it would be a ToolButton even when it's sending

208–211

A button no longer need a TapHandler, just use the button's onClicked signal handler

Make the resend button a ToolButton

nannanko removed a reviewer: servant.

Make the resend button a ToolButton

Fix test for resend button

Make the resend button a ToolButton

This revision is now accepted and ready to land.Jul 18 2024, 11:30 PM
This revision was automatically updated to reflect the committed changes.