Details

Reviewers

tusooa

Group Reviewers

O1: the Kazv Project

Maniphest Tasks

T14: "Unable to send" indicator is not obvious that it is clickable

Commits

rK52593d8e246e: Make the resend button a ToolButton

Summary

"Unable to send" indicator is not obvious that it is clickable, This revision make it a ToolButton.

Type: fix

Test Plan

Make a local echo event.
Verify that the button appears with a border when the mouse is hovered.
Verify that the message is resent when the button is clicked.

Diff Detail

Repository

rK kazv

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 189
Build 367: GitLab CI for kazv
Build 366: arc lint + arc unit

Event Timeline

nannanko created this revision.Jul 13 2024, 6:36 AM

Owners added a reviewer: O1: the Kazv Project.Jul 13 2024, 6:36 AM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 13 2024, 6:52 AM

Harbormaster failed remote builds in B172: Diff 291!

nannanko added a task: T14: "Unable to send" indicator is not obvious that it is clickable.Jul 13 2024, 7:16 AM

Fix tests for resent button

Harbormaster completed remote builds in B174: Diff 293.Jul 13 2024, 7:47 AM

nannanko requested review of this revision.Jul 13 2024, 7:47 AM

You chose the wrong base in the second version.

This revision now requires changes to proceed.Jul 13 2024, 8:04 AM

tusooa added inline comments.Jul 13 2024, 8:06 AM

src/contents/ui/Bubble.qml
194	Which means it would be a ToolButton even when it's sending
208–214	A button no longer need a TapHandler, just use the button's `onClicked` signal handler