Fix kazvtestfixtures withEventSenderId()
ClosedPublic
Actions

Authored by tusooa on Jul 7 2024, 12:09 PM.

Details

Reviewers

nannanko

Group Reviewers

O1: the Kazv Project

Commits

rL0409d774e998: Fix kazvtestfixtures withEventSenderId()

Summary

We incorrectly made it to modify sender_key property, which should not exist in the event.

Type: fix

Test Plan

Verify that all unit tests pass.

Diff Detail

Repository

rL libkazv

Branch

tusooa/stacked

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 149
Build 287: GitLab CI for libkazv
Build 286: arc lint + arc unit

Event Timeline

tusooa created this revision.Jul 7 2024, 12:09 PM

Owners added a reviewer: O1: the Kazv Project.Jul 7 2024, 12:09 PM

Harbormaster completed remote builds in B149: Diff 259.Jul 7 2024, 12:39 PM

tusooa requested review of this revision.Jul 7 2024, 12:39 PM

nannanko accepted this revision.Jul 12 2024, 8:39 PM

This revision is now accepted and ready to land.Jul 12 2024, 8:39 PM

Closed by commit rL0409d774e998: Fix kazvtestfixtures withEventSenderId(). · Explain WhyJul 12 2024, 10:14 PM

This revision was automatically updated to reflect the committed changes.

tusooa added a commit: rL0409d774e998: Fix kazvtestfixtures withEventSenderId().

Revision Contents
Changeset List

Path

Size

Packages

src/

testfixtures/

factory.cpp

2 lines

O1: the Kazv Project

Diff 259

View Options

src/testfixtures/factory.cpp

Fix kazvtestfixtures withEventSenderId()ClosedPublicActions