Page MenuHomePhorge
Differential D93

Make failWithResponse() non-constexpr
ClosedPublic
Actions

Authored by tusooa on Jul 5 2024, 9:44 AM.
Tags
None
Referenced Files
F112525: D93.1732328969.diff
Thu, Nov 21, 6:29 PM
F112517: D93.1732327552.diff
Thu, Nov 21, 6:05 PM
F112445: D93.1732313932.diff
Thu, Nov 21, 2:18 PM
Subscribers
None

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Commits
rLdb4774dd553e: Make failWithResponse() non-constexpr
Summary

failWithResponse() should not be constexpr because nlohmann::json constructor is not constexpr. This might cause problems on some compilers. This commit fixes this problem.

Type: fix

BUG: https://iron.lily-is.land/T99

Test Plan

Verify that all tests pass.

Diff Detail

Repository
rL libkazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tusooa created this revision.Jul 5 2024, 9:44 AM
Owners added a reviewer: O1: the Kazv Project.Jul 5 2024, 9:44 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 5 2024, 1:45 PM
Harbormaster failed remote builds in B135: Diff 231!
Harbormaster completed remote builds in B135: Diff 231.Jul 5 2024, 7:31 PM
tusooa requested review of this revision.Jul 5 2024, 7:31 PM
nannanko accepted this revision.Jul 6 2024, 8:27 AM
This revision is now accepted and ready to land.Jul 6 2024, 8:27 AM
Closed by commit rLdb4774dd553e: Make failWithResponse() non-constexpr. · Explain WhyJul 6 2024, 9:10 AM
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rLdb4774dd553e: Make failWithResponse() non-constexpr.

Revision Contents
Changeset List

Diff 245

View Options

src/client/CMakeLists.txt

Loading...
View Options

src/client/status-utils.hpp

Loading...
View Options

src/client/status-utils.cpp

Loading...