Page MenuHomePhorge
Differential D93

Make failWithResponse() non-constexpr
ClosedPublic
Actions

Authored by tusooa on Jul 5 2024, 9:44 AM.
Tags
None
Referenced Files
F30306: D93.1726897475.diff
Thu, Sep 19, 10:44 PM
Unknown Object (File)
Sat, Sep 14, 7:08 PM
Unknown Object (File)
Thu, Sep 5, 6:26 AM
Unknown Object (File)
Tue, Aug 27, 4:25 PM
Unknown Object (File)
Tue, Aug 27, 2:15 PM
Unknown Object (File)
Tue, Aug 27, 8:29 AM
Unknown Object (File)
Sat, Aug 24, 2:24 PM
Unknown Object (File)
Sat, Aug 24, 6:16 AM
View All 54 Files
Subscribers
None

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Commits
rLdb4774dd553e: Make failWithResponse() non-constexpr
Summary

failWithResponse() should not be constexpr because nlohmann::json constructor is not constexpr. This might cause problems on some compilers. This commit fixes this problem.

Type: fix

BUG: https://iron.lily-is.land/T99

Test Plan

Verify that all tests pass.

Diff Detail

Repository
rL libkazv
Branch
tusooa/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 135
Build 259: GitLab CI for libkazv
Build 258: arc lint + arc unit

Event Timeline

tusooa created this revision.Jul 5 2024, 9:44 AM
Owners added a reviewer: O1: the Kazv Project.Jul 5 2024, 9:44 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 5 2024, 1:45 PM
Harbormaster failed remote builds in B135: Diff 231!
Harbormaster completed remote builds in B135: Diff 231.Jul 5 2024, 7:31 PM
tusooa requested review of this revision.Jul 5 2024, 7:31 PM
nannanko accepted this revision.Jul 6 2024, 8:27 AM
This revision is now accepted and ready to land.Jul 6 2024, 8:27 AM
Closed by commit rLdb4774dd553e: Make failWithResponse() non-constexpr. · Explain WhyJul 6 2024, 9:10 AM
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rLdb4774dd553e: Make failWithResponse() non-constexpr.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)Packages
src/
client/
1 line--O1: the Kazv Project
41 lines50%
Loading...
O1: the Kazv Project
36 lines100%
Loading...
O1: the Kazv Project

Diff 231

View Options

src/client/CMakeLists.txt

Loading...
View Options

src/client/status-utils.hpp

Loading...
View Options

src/client/status-utils.cpp

Loading...