Page MenuHomePhorge
Differential D94

Fix styles for SwipeListItems
ClosedPublic
Actions

Authored by tusooa on Jul 5 2024, 10:22 AM.
Tags
None
Referenced Files
F28947605: D94.1767914974.diff
Wed, Jan 7, 3:29 PM
F28946384: D94.1767914729.diff
Wed, Jan 7, 3:25 PM
F28813133: D94.1767888885.diff
Wed, Jan 7, 8:14 AM
F28723441: D94.1767871266.diff
Wed, Jan 7, 3:21 AM
F28657789: D94.1767858622.diff
Tue, Jan 6, 11:50 PM
Restricted File
Jul 5 2024, 10:26 AM
Restricted File
Jul 5 2024, 10:26 AM
Subscribers
None

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Commits
rK481e53802f13: Fix styles for SwipeListItems
Summary

In KF6, the content of a SwipeListItem needs to be declared as the contentItem in order to be resized properly.

Type: fix

CCBUG: https://iron.lily-is.land/T101

Test Plan

Verify that room list, room member list, device list, room tags, and invitees in create room page are styled properly.

Diff Detail

Repository
rK kazv
Branch
tusooa/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 137
Build 263: GitLab CI for kazv
Build 262: arc lint + arc unit

Event Timeline

tusooa created this revision.Jul 5 2024, 10:22 AM
Owners added a reviewer: O1: the Kazv Project.Jul 5 2024, 10:22 AM
tusooa edited the summary of this revision. (Show Details)Jul 5 2024, 10:25 AM
BeforeAfter
{F5386}{F5387}
tusooa updated this revision to Diff 233.Jul 5 2024, 10:28 AM
tusooa edited the summary of this revision. (Show Details)

Use layout for room tags and invitees in create room page

Harbormaster completed remote builds in B137: Diff 233.Jul 5 2024, 2:52 PM
tusooa requested review of this revision.Jul 5 2024, 2:52 PM
Harbormaster failed remote builds in B136: Diff 232!Jul 5 2024, 3:15 PM
tusooa edited the summary of this revision. (Show Details)Jul 5 2024, 8:11 PM
nannanko accepted this revision.Jul 6 2024, 8:29 AM
This revision is now accepted and ready to land.Jul 6 2024, 8:29 AM
Closed by commit rK481e53802f13: Fix styles for SwipeListItems. · Explain WhyJul 6 2024, 9:13 AM
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rK481e53802f13: Fix styles for SwipeListItems.

Revision Contents
Changeset List

Diff 233

View Options

src/contents/ui/CreateRoomPage.qml

Loading...
View Options

src/contents/ui/RoomListViewItemDelegate.qml

Loading...
View Options

src/contents/ui/RoomMemberListViewItemDelegate.qml

Loading...
View Options

src/contents/ui/device-mgmt/Device.qml

Loading...
View Options

src/contents/ui/room-settings/RoomSettingsPage.qml

Loading...