Page MenuHomePhorge

Make JoinRoomPage auto-closable
ClosedPublic

Authored by tusooa on Jun 30 2024, 8:28 AM.
Tags
None
Referenced Files
F9967903: D84.1762344004.diff
Tue, Nov 4, 4:00 AM
F9967901: D84.1762344000.diff
Tue, Nov 4, 4:00 AM
F9925093: D84.1762330549.diff
Tue, Nov 4, 12:15 AM
F9826052: D84.1762301193.diff
Mon, Nov 3, 4:06 PM
Subscribers
None

Details

Summary

We missed JoinRoomPage in https://iron.lily-is.land/D23 because it is using Kirigami.Page (not Kirigami.ScrollablePage). This commit makes it behave as the other pages.

Type: fix

Test Plan

Verify that you can close a JoinRoomPage by clicking the left arrow on the top-left.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 30 2024, 8:44 AM
Harbormaster failed remote builds in B122: Diff 195!
This revision is now accepted and ready to land.Jul 3 2024, 6:10 PM
This revision was automatically updated to reflect the committed changes.