Page MenuHomePhorge

Make JoinRoomPage auto-closable
ClosedPublic

Authored by tusooa on Jun 30 2024, 8:28 AM.

Details

Summary

We missed JoinRoomPage in https://iron.lily-is.land/D23 because it is using Kirigami.Page (not Kirigami.ScrollablePage). This commit makes it behave as the other pages.

Type: fix

Test Plan

Verify that you can close a JoinRoomPage by clicking the left arrow on the top-left.

Diff Detail

Repository
rK kazv
Branch
tusooa/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 122
Build 233: GitLab CI for kazv
Build 232: arc lint + arc unit

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 30 2024, 8:44 AM
Harbormaster failed remote builds in B122: Diff 195!
This revision is now accepted and ready to land.Jul 3 2024, 6:10 PM
This revision was automatically updated to reflect the committed changes.