Page MenuHomePhorge

Display edited version of events
ClosedPublic

Authored by tusooa on Apr 24 2024, 8:26 PM.
Tags
None
Referenced Files
F112562: D5.1732335018.diff
Thu, Nov 21, 8:10 PM
F112558: D5.1732334627.diff
Thu, Nov 21, 8:03 PM
F112455: D5.1732315622.diff
Thu, Nov 21, 2:47 PM
F112128: D5.1732272006.diff
Thu, Nov 21, 2:40 AM
F112127: D5.1732272004.diff
Thu, Nov 21, 2:40 AM
F112126: D5.1732272003.diff
Thu, Nov 21, 2:40 AM
F112125: D5.1732272000.diff
Thu, Nov 21, 2:40 AM
F112121: D5.1732271782.diff
Thu, Nov 21, 2:36 AM
Subscribers
None

Details

Summary

Display edited version of events

Type: add

Test Plan
  • Open kazv
  • Send a message
  • Edit the message from another client
  • Observe that the message is shown as edited
  • Observe that the standalone edit is not shown in the timeline

Diff Detail

Repository
rK kazv
Branch
stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 7
Build 7: arc lint + arc unit

Event Timeline

tusooa created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Apr 28 2024, 12:55 PM
This revision was automatically updated to reflect the committed changes.

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

This was lost when I pushed my local dev branch to lily. Reopening. @nannanko

@nannanko also it looks like that this would fix the test failure on kazv|servant branch because of the following:

// ignore edits of other events
if (e.relationType === 'm.replace') {
  return 'ignore';
}
This revision is now accepted and ready to land.May 19 2024, 1:17 AM
This revision was automatically updated to reflect the committed changes.