Extract action groups into separate QML files. No behavior changed intended.
Type: skip
Details
Details
Diff Detail
Diff Detail
- Repository
- rK kazv
- Branch
- nannanko/stacked
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 717 Build 1416: Invoke Buildbot Buildbot build #2581 Build 1415: arc lint + arc unit
Event Timeline
Comment Actions
Finally, it does not seem to me that the shortcuts directory is suitable for individual actions. I feel it is a directory to provide tools to interact with actions rather than actions themselves.
| src/contents/ui/Main.qml | ||
|---|---|---|
| 228–242 | This looks a little bit messy. We can reduce the duplication by changing ActionCollection's children property's type to list<QtObject> and directly specify children: [KazvShortcuts.GlobalDrawerActions {}, ...]It would be also good to put the list of children in its own file, say AllActions.qml: KazvShortcuts.ActionCollection {
children: [...]
}and in Main.qml, define the actionCollection to be AllActions {
shortcutsConfig: kazvConfig
} | |
| src/contents/ui/shortcuts/BubbleActions.qml | ||
| 12 | I think it will be more appropriate to use an ActionColection here. | |
| src/contents/ui/shortcuts/BubbleActions.qml | ||
|---|---|---|
| 15–16 | we can declare these two properties in ActionCollection (declare property list<QtObject> actions there because the actions do not necessarily have a common class other than QtObject) | |