Page MenuHomePhorge
Differential D354

Add section header in configure shortcuts page
ClosedPublic
Actions

Authored by nannanko on Sat, Aug 22, 10:12 AM.
Tags
None
Referenced Files
F85696331: D354.1789316058.diff
Sat, Sep 12, 9:14 AM
F85696288: D354.1789314579.diff
Sat, Sep 12, 8:49 AM
F85695046: D354.1789299561.diff
Sat, Sep 12, 4:39 AM
F85693496: D354.1789280316.diff
Fri, Sep 11, 11:18 PM
F85692312: D354.1789265950.diff
Fri, Sep 11, 7:19 PM
F85691951: D354.1789258938.diff
Fri, Sep 11, 5:22 PM
F85691214: D354.1789246522.diff
Fri, Sep 11, 1:55 PM
F85691192: D354.1789245728.diff
Fri, Sep 11, 1:42 PM
Subscribers
None

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Commits
rK82b101396d0f: Add section header in configure shortcuts page
Summary

Add section header in configure shortcuts page

Type: add

Test Plan

Compile and open configure shortcuts page in kazv, check the visibility of section header.

Diff Detail

Repository
rK kazv
Branch
nannanko/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 704
Build 1390: Invoke BuildbotBuildbot build #2499
Build 1389: arc lint + arc unit

Event Timeline

nannanko created this revision.Sat, Aug 22, 10:12 AM
Owners added a reviewer: O1: the Kazv Project.Sat, Aug 22, 10:12 AM
Herald added a reviewer: servant. · View Herald TranscriptSat, Aug 22, 10:12 AM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

Harbormaster completed remote builds in B704: Diff 1090.Sat, Aug 22, 10:47 AM
nannanko requested review of this revision.Sat, Aug 22, 10:47 AM
nannanko edited the summary of this revision. (Show Details)Sat, Aug 22, 11:01 AM
nannanko removed a reviewer: servant.
tusooa requested changes to this revision.Sun, Aug 23, 12:53 PM
tusooa mentioned this in D357: Fix configure shortcuts page show wrong section header text.

I recommend D357 to be merged into this

This revision now requires changes to proceed.Sun, Aug 23, 12:53 PM
nannanko updated this revision to Diff 1098.Mon, Aug 24, 9:27 AM

Merge D357

Harbormaster completed remote builds in B710: Diff 1098.Mon, Aug 24, 10:07 AM
tusooa accepted this revision.Tue, Aug 25, 2:43 PM
This revision is now accepted and ready to land.Tue, Aug 25, 2:43 PM
Closed by commit rK82b101396d0f: Add section header in configure shortcuts page. · Explain WhySat, Aug 29, 7:35 PM
This revision was automatically updated to reflect the committed changes.
nannanko added a commit: rK82b101396d0f: Add section header in configure shortcuts page.

Revision Contents
Changeset List

Diff 1090

View Options

src/contents/ui/ActionSettingsPage.qml

Loading...
View Options

src/contents/ui/Main.qml

Loading...
View Options

src/contents/ui/shortcuts/ActionCollection.qml

Loading...
View Options

src/contents/ui/shortcuts/ActionSettings.qml

Loading...
View Options

src/l10n/cmn-Hans/100-ui.ftl

Loading...
View Options

src/l10n/en/100-ui.ftl

Loading...