Page MenuHomePhorge

Fix configure shortcuts page show wrong section header text
Needs ReviewPublic

Authored by nannanko on Sat, Aug 22, 9:41 PM.

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Summary

The section headers on the configure shortcuts page always showed the wrong group name (e.g. "Dialog Actions" displaying as "Global Actions"), and the wrong text changed while scrolling. Grouping itself was always correct; only header texts were corrupted. This comes from known Qt defects in ListView's internal section-header cache/reuse path QTBUG-142235. We no longer rely on ListView's implicit section mechanism: headers are now regular list entries bound directly to our own model data, so they cannot be corrupted by view-internal caching.

Type: fix

Test Plan

Verify the correct section header in kazv configure shortcuts page.

Diff Detail

Repository
rK kazv
Branch
nannanko/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 708
Build 1398: Invoke BuildbotBuildbot build #2515
Build 1397: arc lint + arc unit

Event Timeline

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

nannanko removed a reviewer: servant.
Harbormaster returned this revision to the author for changes because remote builds failed.Sat, Aug 22, 10:03 PM
Harbormaster failed remote builds in B708: Diff 1094!