Page MenuHomePhorge
Differential D346

Port to KConfigXT
ClosedPublic
Actions

Authored by nannanko on Sat, Aug 8, 12:46 PM.
Tags
None
Referenced Files
F85651328: D346.1788051423.diff
Fri, Aug 28, 5:57 PM
F85651294: D346.1788047068.diff
Fri, Aug 28, 4:44 PM
F85651201: D346.1788035076.diff
Fri, Aug 28, 1:24 PM
F85651123: D346.1788032062.diff
Fri, Aug 28, 12:34 PM
Subscribers
None

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Commits
rK0b7b7f11c2ee: Port to KConfigXT
Summary

Port to KConfigXT

Type: add

Test Plan

Compile and open kazv, verify that all config are correct.

Veridy unit tests pass.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nannanko created this revision.Sat, Aug 8, 12:46 PM
Owners added a reviewer: O1: the Kazv Project.Sat, Aug 8, 12:46 PM
Harbormaster completed remote builds in B690: Diff 1066.Sat, Aug 8, 1:19 PM
nannanko requested review of this revision.Sat, Aug 8, 1:19 PM
tusooa requested changes to this revision.Thu, Aug 13, 7:40 PM
tusooa added inline comments.
src/kazv-settings.kcfg
7

Is it possible to use QStandardPaths::AppConfigLocation instead of hard-coding a directory?

This revision now requires changes to proceed.Thu, Aug 13, 7:40 PM
nannanko added inline comments.Sat, Aug 15, 10:22 AM
src/kazv-settings.kcfg
7

Is it possible to use QStandardPaths::AppConfigLocation instead of hard-coding a directory?

The constructor of KConfigXT is fixed to GeneralConfigLocation, it seems there is no official support.

tusooa added inline comments.Sat, Aug 15, 7:15 PM
src/kazv-settings.kcfg
7

https://api.kde.org/kconfigcompiler.html

The <kcfgfile> tag may contain either the "name" attribute, which should be the name of the configuration file described, or the "arg" attribute, which, if set to "true", will allow you to pass the KSharedConfig::Ptr object to use.

nannanko updated this revision to Diff 1080.Sun, Aug 16, 9:00 AM

Port to AppConfigLocation.

Harbormaster failed remote builds in B699: Diff 1080!Sun, Aug 16, 9:03 AM
nannanko marked 2 inline comments as done.Sun, Aug 16, 9:24 AM
tusooa accepted this revision.Wed, Aug 19, 11:57 AM
This revision is now accepted and ready to land.Wed, Aug 19, 11:57 AM
This revision was landed with ongoing or failed builds.Sat, Aug 22, 4:37 AM
Closed by commit rK0b7b7f11c2ee: Port to KConfigXT. · Explain Why
This revision was automatically updated to reflect the committed changes.
nannanko added a commit: rK0b7b7f11c2ee: Port to KConfigXT.

Revision Contents
Changeset List

Diff 1087

View Options

src/CMakeLists.txt

Loading...
View Options

src/kazv-config.hpp

Loading...
View Options

src/kazv-config.cpp

Loading...
View Options

src/kazv-sessions-settings.kcfg

Loading...
View Options

src/kazv-settings.kcfg

Loading...
View Options

src/tests/CMakeLists.txt

Loading...
View Options

src/tests/kazv-config-test.cpp

Loading...