Page MenuHomePhorge

Port to KConfigXT
Needs ReviewPublic

Authored by nannanko on Sat, Aug 8, 12:46 PM.

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Summary

Port to KConfigXT

Type: add

Test Plan

Compile and open kazv, verify that all config are correct.

Veridy unit tests pass.

Diff Detail

Repository
rK kazv
Branch
nannanko/port-to-kconfigxt
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 699
Build 1380: Invoke BuildbotBuildbot build #2457
Build 1379: arc lint + arc unit

Event Timeline

tusooa requested changes to this revision.Thu, Aug 13, 7:40 PM
tusooa added inline comments.
src/kazv-settings.kcfg
7

Is it possible to use QStandardPaths::AppConfigLocation instead of hard-coding a directory?

This revision now requires changes to proceed.Thu, Aug 13, 7:40 PM
src/kazv-settings.kcfg
7

Is it possible to use QStandardPaths::AppConfigLocation instead of hard-coding a directory?

The constructor of KConfigXT is fixed to GeneralConfigLocation, it seems there is no official support.

src/kazv-settings.kcfg
7

https://api.kde.org/kconfigcompiler.html

The <kcfgfile> tag may contain either the "name" attribute, which should be the name of the configuration file described, or the "arg" attribute, which, if set to "true", will allow you to pass the KSharedConfig::Ptr object to use.

Port to AppConfigLocation.