Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F113350
D123.1732450282.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D123.1732450282.diff
View Options
diff --git a/src/matrix-room-list.cpp b/src/matrix-room-list.cpp
--- a/src/matrix-room-list.cpp
+++ b/src/matrix-room-list.cpp
@@ -113,11 +113,9 @@
const auto &roomB = allRooms[idB];
auto aIsInvite = roomA.membership == Invite;
auto bIsInvite = roomB.membership == Invite;
- auto aIsFavourite = roomA.tags().find("m.favourite") != nullptr;
- auto bIsFavourite = roomB.tags().find("m.favourite") != nullptr;
- if (aIsFavourite != bIsFavourite) {
- return aIsFavourite;
- } else if (aIsInvite != bIsInvite) {
+ auto aIsFavourite = roomA.tags().count("m.favourite") == 1;
+ auto bIsFavourite = roomB.tags().count("m.favourite") == 1;
+ if (aIsInvite != bIsInvite) {
/**
* if my membership in A is invite,
* then the membership in B is not invite,
@@ -125,6 +123,8 @@
* otherwise B should come first
**/
return aIsInvite;
+ } else if (aIsFavourite != bIsFavourite) {
+ return aIsFavourite;
} else {
return latestEventTimestamp(roomA)
> latestEventTimestamp(roomB);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Nov 24, 4:11 AM (10 h, 44 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
39574
Default Alt Text
D123.1732450282.diff (1 KB)
Attached To
Mode
D123: Show favourite rooms at the top
Attached
Detach File
Event Timeline
Log In to Comment