Page MenuHomePhorge

Make failWithResponse() non-constexpr
ClosedPublic

Authored by tusooa on Fri, Jul 5, 9:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 19, 10:25 PM
Unknown Object (File)
Fri, Jul 19, 10:25 PM
Unknown Object (File)
Sun, Jul 14, 9:42 PM
Unknown Object (File)
Sun, Jul 14, 7:33 PM
Unknown Object (File)
Sat, Jul 13, 7:26 PM
Unknown Object (File)
Sat, Jul 13, 3:14 PM
Unknown Object (File)
Sat, Jul 13, 7:25 AM
Unknown Object (File)
Thu, Jul 11, 10:23 PM
Subscribers
None

Details

Summary

failWithResponse() should not be constexpr because nlohmann::json constructor is not constexpr. This might cause problems on some compilers. This commit fixes this problem.

Type: fix

BUG: https://iron.lily-is.land/T99

Test Plan

Verify that all tests pass.

Diff Detail

Repository
rL libkazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Jul 5, 1:45 PM
Harbormaster failed remote builds in B135: Diff 231!
tusooa requested review of this revision.Fri, Jul 5, 7:31 PM
This revision is now accepted and ready to land.Sat, Jul 6, 8:27 AM
This revision was automatically updated to reflect the committed changes.