Page MenuHomePhorge
Differential D90

Add forget room button for RoomSettingPage
ClosedPublic
Actions

Authored by nannanko on Jul 4 2024, 7:54 PM.

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Commits
rK1d43ad679307: Add forget room button for RoomSettingPage
Summary

This enable the user to forget room.

Type: add

Test Plan

Verify unit tests pass. Click forget room in room setting page and accept, verify that notification of successful or failed appears.

Diff Detail

Repository
rK kazv
Branch
servant
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 133
Build 255: GitLab CI for kazv
Build 254: arc lint + arc unit

Event Timeline

nannanko created this revision.Jul 4 2024, 7:54 PM
Owners added a reviewer: O1: the Kazv Project.Jul 4 2024, 7:54 PM
nannanko added a reviewer: tusooa.Jul 4 2024, 7:56 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 4 2024, 9:15 PM
Harbormaster failed remote builds in B131: Diff 226!
tusooa added inline comments.Jul 4 2024, 9:50 PM
src/tests/quick-tests/tst_RoomSettingsPage.qml
108–109

can we also test on showPassiveNotification being called after the promise is resolved?

Harbormaster completed remote builds in B131: Diff 226.Jul 4 2024, 11:43 PM
nannanko requested review of this revision.Jul 4 2024, 11:43 PM
nannanko updated this revision to Diff 229.Jul 5 2024, 12:53 AM
  • Add test on showPassiveNotification being called after the promise is resolved
nannanko marked an inline comment as done.Jul 5 2024, 12:58 AM
Harbormaster completed remote builds in B133: Diff 229.Jul 5 2024, 2:38 AM
tusooa added inline comments.Jul 5 2024, 9:58 AM
src/l10n/en/100-ui.ftl
256
tusooa accepted this revision.Jul 5 2024, 10:00 AM

Otherwise good

This revision is now accepted and ready to land.Jul 5 2024, 10:00 AM
Closed by commit rK1d43ad679307: Add forget room button for RoomSettingPage. · Explain WhyJul 6 2024, 8:37 AM
This revision was automatically updated to reflect the committed changes.
nannanko added a commit: rK1d43ad679307: Add forget room button for RoomSettingPage.

Revision Contents
Changeset List

Diff 229

View Options

src/contents/ui/room-settings/RoomSettingsPage.qml

Loading...
View Options

src/l10n/cmn-Hans/100-ui.ftl

Loading...
View Options

src/l10n/en/100-ui.ftl

Loading...
View Options

src/matrix-room.hpp

Loading...
View Options

src/matrix-room.cpp

Loading...
View Options

src/tests/quick-tests/tst_RoomSettingsPage.qml

Loading...