Page MenuHomePhorge

Add forget room button for RoomSettingPage
ClosedPublic

Authored by nannanko on Thu, Jul 4, 7:54 PM.
Tags
None
Referenced Files
F7914: D90.1721614041.diff
Sat, Jul 20, 7:07 PM
Unknown Object (File)
Fri, Jul 19, 10:40 PM
Unknown Object (File)
Thu, Jul 18, 1:55 AM
Unknown Object (File)
Sun, Jul 14, 9:06 AM
Unknown Object (File)
Thu, Jul 11, 6:23 PM
Unknown Object (File)
Thu, Jul 11, 3:23 PM
Unknown Object (File)
Thu, Jul 11, 9:22 AM
Unknown Object (File)
Wed, Jul 10, 1:45 PM
Subscribers
None

Details

Summary

This enable the user to forget room.

Type: add

Test Plan

Verify unit tests pass. Click forget room in room setting page and accept, verify that notification of successful or failed appears.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Jul 4, 9:15 PM
Harbormaster failed remote builds in B131: Diff 226!
src/tests/quick-tests/tst_RoomSettingsPage.qml
108–109

can we also test on showPassiveNotification being called after the promise is resolved?

  • Add test on showPassiveNotification being called after the promise is resolved
src/l10n/en/100-ui.ftl
256
This revision is now accepted and ready to land.Fri, Jul 5, 10:00 AM