Page MenuHomePhorge
Differential D84

Make JoinRoomPage auto-closable
ClosedPublic
Actions

Authored by tusooa on Jun 30 2024, 8:28 AM.
Tags
None
Referenced Files
F13627724: D84.1765256246.diff
Sun, Dec 7, 8:57 PM
F13627723: D84.1765256238.diff
Sun, Dec 7, 8:57 PM
F13627722: D84.1765256236.diff
Sun, Dec 7, 8:57 PM
F13627721: D84.1765256234.diff
Sun, Dec 7, 8:57 PM
F13625798: D84.1765252531.diff
Sun, Dec 7, 7:55 PM
F13609645: D84.1765223970.diff
Sun, Dec 7, 11:59 AM
F13591617: D84.1765193252.diff
Sun, Dec 7, 3:27 AM
Subscribers
None

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Commits
rK035c218fda35: Make JoinRoomPage auto-closable
Summary

We missed JoinRoomPage in https://iron.lily-is.land/D23 because it is using Kirigami.Page (not Kirigami.ScrollablePage). This commit makes it behave as the other pages.

Type: fix

Test Plan

Verify that you can close a JoinRoomPage by clicking the left arrow on the top-left.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tusooa created this revision.Jun 30 2024, 8:28 AM
Owners added a reviewer: O1: the Kazv Project.Jun 30 2024, 8:28 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 30 2024, 8:44 AM
Harbormaster failed remote builds in B122: Diff 195!
tusooa updated this revision to Diff 196.Jun 30 2024, 8:47 AM

Fix tests under KF6

Harbormaster completed remote builds in B123: Diff 196.Jun 30 2024, 9:03 AM
tusooa requested review of this revision.Jun 30 2024, 9:03 AM
nannanko accepted this revision.Jul 3 2024, 6:10 PM
This revision is now accepted and ready to land.Jul 3 2024, 6:10 PM
Closed by commit rK035c218fda35: Make JoinRoomPage auto-closable. · Explain WhyJul 3 2024, 6:39 PM
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rK035c218fda35: Make JoinRoomPage auto-closable.

Revision Contents
Changeset List

PathSizePackages
src/
contents/
ui/
2 linesO1: the Kazv Project
tests/
quick-tests/
6 linesO1: the Kazv Project

Diff 221

View Options

src/contents/ui/JoinRoomPage.qml

Loading...
View Options

src/tests/quick-tests/tst_JoinRoomPage.qml

Loading...