Differential D70

Do not verify sender key and sender device id for megolm events
ClosedPublic
Actions

Authored by tusooa on Jun 23 2024, 9:12 PM.

Details

Reviewers

nannanko

Group Reviewers

O1: the Kazv Project

Commits

rL69e4fb74ed3b: Do not verify sender key and sender device id for megolm events

Summary

The spec says we should not verify them. This makes us conform to it.

Type: fix

BUG: https://iron.lily-is.land/T98

Test Plan

Verify that all tests pass.
Build kazv against this. Verify you can still receive encrypted messages.

Diff Detail

Repository

rL libkazv

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tusooa created this revision.Jun 23 2024, 9:12 PM

Owners added a reviewer: O1: the Kazv Project.Jun 23 2024, 9:12 PM

Harbormaster completed remote builds in B101: Diff 151.Jun 23 2024, 10:00 PM

tusooa requested review of this revision.Jun 23 2024, 10:00 PM

nannanko accepted this revision.Jul 3 2024, 5:48 PM

This revision is now accepted and ready to land.Jul 3 2024, 5:48 PM

Closed by commit rL69e4fb74ed3b: Do not verify sender key and sender device id for megolm events. · Explain WhyJul 3 2024, 6:34 PM

This revision was automatically updated to reflect the committed changes.

tusooa added a commit: rL69e4fb74ed3b: Do not verify sender key and sender device id for megolm events.

Revision Contents
Changeset List

Path

Size

Packages

src/

client/

actions/

encryption.cpp

36 lines

O1: the Kazv Project

tests/

client/

encryption-test.cpp

48 lines

O1: the Kazv Project

Diff 207

View Options

src/client/actions/encryption.cpp

View Options

src/tests/client/encryption-test.cpp

Do not verify sender key and sender device id for megolm eventsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 207

src/client/actions/encryption.cpp

src/tests/client/encryption-test.cpp

Do not verify sender key and sender device id for megolm events
ClosedPublic
Actions

Revision Contents
Changeset List