Page MenuHomePhorge
Differential D364

Added support for rounded corners on send message box
Needs ReviewPublic
Actions

Authored by nannanko on Sat, Sep 26, 1:03 PM.
Tags
None
Referenced Files
F85807584: D364.1791922566.diff
Mon, Oct 12, 1:16 PM
F85807306: D364.1791900639.diff
Mon, Oct 12, 7:10 AM
F85807195: D364.1791884971.diff
Mon, Oct 12, 2:49 AM
F85806937: D364.1791845889.diff
Sun, Oct 11, 3:58 PM
F85793595: IMG20260927032836.jpg
Sat, Sep 26, 1:42 PM
F85793596: IMG20260927032913.jpg
Sat, Sep 26, 1:42 PM
F85793600: IMG_20260719_100822.jpg
Sat, Sep 26, 1:42 PM
Subscribers
None

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Summary

Most modern Android devices feature physical rounded corners, which causes the Kazv UI to be clipped on these devices. This diff uses getRoundedCorner (introduced in Android SDK 31) to retrieve device corner information and applies appropriate margins to the SendMessageBox.

Type: add

Test Plan

Package the apk for android, verify the send message box is not clipped by rounded corners.

Diff Detail

Repository
rK kazv
Branch
nannanko/android-round-corner
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 731
Build 1444: Invoke BuildbotBuildbot build #2767
Build 1443: arc lint + arc unit

Event Timeline

nannanko created this revision.Sat, Sep 26, 1:03 PM
Owners added a reviewer: O1: the Kazv Project.Sat, Sep 26, 1:03 PM
Herald added a reviewer: servant. · View Herald TranscriptSat, Sep 26, 1:03 PM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

nannanko edited the summary of this revision. (Show Details)Sat, Sep 26, 1:06 PM
nannanko removed a reviewer: servant.
Harbormaster completed remote builds in B722: Diff 1117.Sat, Sep 26, 1:31 PM
nannanko requested review of this revision.Sat, Sep 26, 1:31 PM
nannanko added a comment.Sat, Sep 26, 1:42 PM

Before:

IMG_20260719_100822.jpg (1×1 px, 113 KB)

After:

IMG20260927032913.jpg (4×3 px, 4 MB)

IMG20260927032836.jpg (4×3 px, 4 MB)

tusooa added inline comments.Sat, Sep 26, 7:41 PM
src/kazv-util.cpp
131

Can we cache the result so that the operation gets executed only once? Thread switching is pretty expensive.

nannanko updated this revision to Diff 1119.Thu, Oct 1, 1:48 AM

Add cache for screen corner radius

nannanko marked an inline comment as done.Thu, Oct 1, 1:48 AM
Harbormaster completed remote builds in B724: Diff 1119.Thu, Oct 1, 2:17 AM
tusooa requested changes to this revision.Sat, Oct 3, 5:59 PM
tusooa added inline comments.
src/contents/ui/RoomPage.qml
191

Can we leave the top padding as default?

195–196

move this into KazvUtil. note that we may have other items that rely on this value in the future

This revision now requires changes to proceed.Sat, Oct 3, 5:59 PM
nannanko updated this revision to Diff 1127.Mon, Oct 12, 9:05 AM
  • leave the top padding as default
  • move cornerRadius into KazvUtil
  • Standardized Naming
Harbormaster completed remote builds in B731: Diff 1127.Mon, Oct 12, 9:36 AM
nannanko marked 2 inline comments as done.Mon, Oct 12, 10:04 AM

Revision Contents
Changeset List

Diff 1127

View Options

src/contents/ui/RoomPage.qml

Loading...
View Options

src/kazv-config.hpp

Loading...
View Options

src/kazv-config.cpp

Loading...
View Options

src/kazv-settings.kcfg

Loading...
View Options

src/kazv-util.hpp

Loading...
View Options

src/kazv-util.cpp

Loading...
View Options

src/tests/quick-tests/tst_PageManager.qml

Loading...
View Options

src/tests/quick-tests/tst_RoomPage.qml

Loading...