Page MenuHomePhorge
Differential D364

Added support for rounded corners on send message box
Needs ReviewPublic
Actions

Authored by nannanko on Sat, Sep 26, 1:03 PM.

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Summary

Most modern Android devices feature physical rounded corners, which causes the Kazv UI to be clipped on these devices. This diff uses getRoundedCorner (introduced in Android SDK 31) to retrieve device corner information and applies appropriate margins to the SendMessageBox.

Type: add

Test Plan

Package the apk for android, verify the send message box is not clipped by rounded corners.

Diff Detail

Repository
rK kazv
Branch
servant
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 722
Build 1426: Invoke BuildbotBuildbot build #2713
Build 1425: arc lint + arc unit

Event Timeline

nannanko created this revision.Sat, Sep 26, 1:03 PM
Owners added a reviewer: O1: the Kazv Project.Sat, Sep 26, 1:03 PM
Herald added a reviewer: servant. · View Herald TranscriptSat, Sep 26, 1:03 PM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

nannanko edited the summary of this revision. (Show Details)Sat, Sep 26, 1:06 PM
nannanko removed a reviewer: servant.
Harbormaster completed remote builds in B722: Diff 1117.Sat, Sep 26, 1:31 PM
nannanko requested review of this revision.Sat, Sep 26, 1:31 PM
nannanko added a comment.Sat, Sep 26, 1:42 PM

Before:

IMG_20260719_100822.jpg (1×1 px, 113 KB)

After:

IMG20260927032913.jpg (4×3 px, 4 MB)

IMG20260927032836.jpg (4×3 px, 4 MB)

tusooa added inline comments.Sat, Sep 26, 7:41 PM
src/kazv-util.cpp
124

Can we cache the result so that the operation gets executed only once? Thread switching is pretty expensive.

Revision Contents
Changeset List

Diff 1117

View Options

src/contents/ui/RoomPage.qml

Loading...
View Options

src/kazv-util.hpp

Loading...
View Options

src/kazv-util.cpp

Loading...