Differential D343

Catch exceptions in Crypto::decrypt()
ClosedPublic
Actions

Authored by tusooa on Mon, Aug 3, 8:20 PM.

Details

Reviewers

nannanko

Group Reviewers

O1: the Kazv Project

Maniphest Tasks

T130: Crypto::decrypt() may throw an exception

Commits

rLb5c136c2832b: Catch exceptions in Crypto::decrypt()

Summary

This fixes the problem where a malformed event leads to an uncaught exception in Crypto::decrypt(), potentially crashing the application.

Type: fix

BUG: https://iron.lily-is.land/T130

Test Plan

Check unit tests pass.

Diff Detail

Repository

rL libkazv

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tusooa created this revision.Mon, Aug 3, 8:20 PM

Owners added a reviewer: O1: the Kazv Project.Mon, Aug 3, 8:20 PM

Harbormaster completed remote builds in B687: Diff 1062.Mon, Aug 3, 8:44 PM

tusooa requested review of this revision.Mon, Aug 3, 8:44 PM

tusooa added a task: T130: Crypto::decrypt() may throw an exception.Mon, Aug 3, 9:57 PM

nannanko accepted this revision.Sat, Aug 8, 6:56 AM

This revision is now accepted and ready to land.Sat, Aug 8, 6:56 AM

Closed by commit rLb5c136c2832b: Catch exceptions in Crypto::decrypt(). · Explain WhySat, Aug 8, 7:39 PM

This revision was automatically updated to reflect the committed changes.

tusooa added a commit: rLb5c136c2832b: Catch exceptions in Crypto::decrypt().

Revision Contents
Changeset List

Path

Size

Packages

src/

crypto/

18 lines

tests/

30 lines

Diff 1068

View Options

src/crypto/crypto.cpp

View Options

Catch exceptions in Crypto::decrypt()ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1068

src/crypto/crypto.cpp

src/tests/crypto-test.cpp

Catch exceptions in Crypto::decrypt()
ClosedPublic
Actions

Revision Contents
Changeset List