Details

Reviewers

tusooa

Group Reviewers

O1: the Kazv Project

Commits

rK59db6245f5df: Port KIO to QNetwork

Summary

KIO don't work on Andoird, This diff port to QNetwork.

Type: fix

Test Plan

Verify all feature about download/upload works fine.
Verify unit tests pass.

Diff Detail

Repository

rK kazv

Branch

nannanko/port-to-qtnetwork

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 677
Build 1336: Invoke Buildbot	Buildbot build #2206
Build 1335: arc lint + arc unit

Event Timeline

nannanko created this revision.Sat, Jul 18, 12:51 PM

Owners added a reviewer: O1: the Kazv Project.Sat, Jul 18, 12:51 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Sat, Jul 18, 1:13 PM

Harbormaster failed remote builds in B670: Diff 1029!

Thank you!

nannanko added a comment.Sat, Jul 25, 11:54 AM

This comment was removed by nannanko.

Add suspend/resume

In D331#6584, @tusooa wrote:

Thank you!

^_−☆

nannanko published this revision for review.Sat, Jul 25, 2:18 PM

Harbormaster failed remote builds in B677: Diff 1038!Sat, Jul 25, 2:40 PM

tusooa requested changes to this revision.Sat, Jul 25, 7:09 PM

tusooa added inline comments.

src/kazv-file.cpp
70–80

This revision now requires changes to proceed.Sat, Jul 25, 7:09 PM

make isSuspend bool

nannanko planned changes to this revision.Sat, Jul 25, 7:35 PM

nannanko marked an inline comment as done.

Harbormaster failed remote builds in B678: Diff 1041!Sat, Jul 25, 7:59 PM

nannanko edited the summary of this revision. (Show Details)Sun, Jul 26, 8:56 AM

Fix tests.

Harbormaster completed remote builds in B679: Diff 1042.Sun, Jul 26, 10:23 AM

This functionally works.

This revision is now accepted and ready to land.Wed, Jul 29, 2:31 PM

Closed by commit rK59db6245f5df: Port KIO to QNetwork. · Explain WhySat, Aug 1, 6:00 AM

This revision was automatically updated to reflect the committed changes.

nannanko added a commit: rK59db6245f5df: Port KIO to QNetwork.

Port KIO to QNetwork
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 1038

CMakeLists.txt

README.md

packaging/GNU-Linux/appimage/build.sh

src/CMakeLists.txt

src/contents/ui/Main.qml

src/kazv-file.hpp

src/kazv-file.cpp

src/kazv-io-job.hpp

src/kazv-io-job.cpp

src/kazv-io-manager.hpp

src/kazv-io-manager.cpp

src/tests/kazv-io-job-test.cpp

src/tests/quick-tests/test-helpers/KazvIOManagerMock.qml

src/tests/quick-tests/tst_KazvIOMenu.qml

Port KIO to QNetworkClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1038

CMakeLists.txt

README.md

packaging/GNU-Linux/appimage/build.sh

src/CMakeLists.txt

src/contents/ui/Main.qml

src/kazv-file.hpp

src/kazv-file.cpp

src/kazv-io-job.hpp

src/kazv-io-job.cpp

src/kazv-io-manager.hpp

src/kazv-io-manager.cpp

src/tests/kazv-io-job-test.cpp

src/tests/quick-tests/test-helpers/KazvIOManagerMock.qml

src/tests/quick-tests/tst_KazvIOMenu.qml

Port KIO to QNetwork
ClosedPublic
Actions

Revision Contents
Changeset List