Page MenuHomePhorge
Differential D312

Fix freeze when use scroll bar
Changes PlannedPublicDraft
Actions

Authored by nannanko on Sat, Jun 20, 8:01 AM.

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Summary

Fix freeze when use scroll bar.

Type: fix

Test Plan

Open a room with enough events, drag the scroll bar and verify that the kazv don't freezes.

Diff Detail

Repository
rK kazv
Branch
nannanko/scroll-freeze
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 635
Build 1252: Invoke BuildbotBuildbot build #1880
Build 1251: arc lint + arc unit

Event Timeline

nannanko created this revision.Sat, Jun 20, 8:01 AM
Owners added a reviewer: O1: the Kazv Project.Sat, Jun 20, 8:01 AM
nannanko updated this revision to Diff 978.Sat, Jun 20, 8:18 AM

scrollBar.size has a minimum of 0.05; use the actual size to rescale position

Harbormaster failed remote builds in B634: Diff 977!Sat, Jun 20, 8:34 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Sat, Jun 20, 9:05 AM
Harbormaster failed remote builds in B635: Diff 978!
tusooa added inline comments.Sat, Jul 4, 7:23 PM
src/contents/ui/RoomPage.qml
149

Add comments on why this fixes the problem

149–173

Need to implement onIncreaseAction and onDecreaseAction, otherwise accessibility tools cannot function on this scroll bar:

https://doc.qt.io/qt-6/qml-qtquick-accessible.html#increaseAction-signal

Revision Contents
Changeset List

Diff 978

View Options

src/contents/ui/RoomPage.qml

Loading...
View Options

src/contents/ui/RoomTimelineView.qml

Loading...