Fix compiler warnings
Needs ReviewPublic
Actions

Authored by tusooa on Thu, Jun 11, 2:57 PM.

Details

Reviewers

None

Group Reviewers

Summary

Fix unused parameters, implicit this capture and unused local variables. This also fixes a bug in CprJobHandler and LagerStoreEventEmitter that does not correctly remove timers/listeners from the list.

Type: fix

The code is generated by OpenCode (DeepSeek V4 Pro). tusooa has reviewed it and takes full responsibility for the code.

Test Plan

Go to build logs and ensure no compiler warnings are present.
Verify unit tests pass. Build kazv against this and verify everything still works.

Diff Detail

Repository

rL libkazv

Branch

tusooa/stacked

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 626
Build 1234: Invoke Buildbot	Buildbot build #1827
Build 1233: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	0 ms	Coverage (build:coverage) https://b.lily-is.land/#/builders/42/builds/78

Event Timeline

tusooa created this revision.Thu, Jun 11, 2:57 PM

Owners added a reviewer: O1: the Kazv Project.Thu, Jun 11, 2:57 PM

tusooa edited the test plan for this revision. (Show Details)Thu, Jun 11, 2:58 PM

tusooa edited the test plan for this revision. (Show Details)

tusooa edited the summary of this revision. (Show Details)Thu, Jun 11, 3:12 PM

Enable -Werror on CI

Harbormaster failed remote builds in B626: Diff 961!Thu, Jun 11, 3:34 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Jun 11, 4:18 PM

Harbormaster failed remote builds in B627: Diff 962!

Disable -Werror

It seems that we cannot use -Werror because immer does not like it

Harbormaster completed remote builds in B628: Diff 963.Thu, Jun 11, 5:53 PM

tusooa requested review of this revision.Thu, Jun 11, 5:53 PM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

client/

actions/

auth.cpp

2 lines

56%

O1: the Kazv Project

client-model.cpp

2 lines

87%

O1: the Kazv Project

client.cpp

2 lines

59%

O1: the Kazv Project

push-rules-desc.cpp

6 lines

85%

O1: the Kazv Project

room/

local-echo.hpp

4 lines

95%

O1: the Kazv Project

crypto/

crypto.cpp

8 lines

89%

O1: the Kazv Project

session.cpp

12 lines

88%

O1: the Kazv Project

eventemitter/

lagerstoreeventemitter.hpp

6 lines

100%

O1: the Kazv Project

job/

cprjobhandler.cpp

41 lines

30%

O1: the Kazv Project

tests/

crypto-test.cpp

3 lines

O1: the Kazv Project

event-emitter-test.cpp

86 lines

O1: the Kazv Project

kazvjobtest.cpp

65 lines

O1: the Kazv Project

Diff 961

View Options

src/client/actions/auth.cpp

View Options

src/client/client-model.cpp

View Options

src/client/client.cpp

View Options

src/client/push-rules-desc.cpp

View Options

src/client/room/local-echo.hpp

View Options

src/crypto/crypto.cpp

View Options

src/crypto/session.cpp

View Options

src/eventemitter/lagerstoreeventemitter.hpp

View Options

src/job/cprjobhandler.cpp

View Options

src/tests/crypto-test.cpp

View Options

src/tests/event-emitter-test.cpp

View Options

Fix compiler warningsNeeds ReviewPublicActions

Details

Diff Detail

Unit TestsFailedView All

Event Timeline

Revision ContentsChangeset List

Diff 961

src/client/actions/auth.cpp

src/client/client-model.cpp

src/client/client.cpp

src/client/push-rules-desc.cpp

src/client/room/local-echo.hpp

src/crypto/crypto.cpp

src/crypto/session.cpp

src/eventemitter/lagerstoreeventemitter.hpp

src/job/cprjobhandler.cpp

src/tests/crypto-test.cpp

src/tests/event-emitter-test.cpp

src/tests/kazvjobtest.cpp

Fix compiler warnings
Needs ReviewPublic
Actions

Unit TestsFailed
View All

Revision Contents
Changeset List