Page MenuHomePhorge
Differential D298

Implement SAS verification
ClosedPublic
Actions

Authored by tusooa on Fri, Mar 27, 9:49 PM.
Tags
None
Referenced Files
F62673635: D298.1775920113.diff
Fri, Apr 10, 8:08 AM
F62619506: D298.1775914498.diff
Fri, Apr 10, 6:34 AM
F62559089: D298.1775908135.diff
Fri, Apr 10, 4:48 AM
F62533090: D298.1775905397.diff
Fri, Apr 10, 4:03 AM
F62525760: D298.1775904661.diff
Fri, Apr 10, 3:51 AM
F62508840: D298.1775902833.diff
Fri, Apr 10, 3:20 AM
F62410132: D298.1775892636.diff
Fri, Apr 10, 12:30 AM
F62261846: D298.1775876683.diff
Thu, Apr 9, 8:04 PM
Subscribers
None

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Maniphest Tasks
T156: SAS verification
Commits
rKf7b74071a07a: Implement SAS verification
Summary

This is the 4th part of https://iron.lily-is.land/T156 . It implements a UI for verification.

Sending outbound verification requests will be implemented in the next and final part.

Type: add

Test Plan

Verify this device from another client. Open "Device Verification" page. Verify you can proceed with the verification. After the verification, make sure that the verified device in the device list is shown as "Verified" instead of "Unseen."

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tusooa created this revision.Fri, Mar 27, 9:49 PM
Owners added a reviewer: O1: the Kazv Project.Fri, Mar 27, 9:49 PM
tusooa added a task: T156: SAS verification.Fri, Mar 27, 9:49 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Mar 27, 10:17 PM
Harbormaster failed remote builds in B588: Diff 904!
tusooa edited the summary of this revision. (Show Details)Sat, Mar 28, 5:34 AM
tusooa updated this revision to Diff 905.Sat, Mar 28, 8:04 AM

better UI, tests

Harbormaster returned this revision to the author for changes because remote builds failed.Sat, Mar 28, 8:12 AM
Harbormaster failed remote builds in B589: Diff 905!
tusooa edited the test plan for this revision. (Show Details)Sat, Mar 28, 7:05 PM
tusooa requested review of this revision.Sat, Apr 4, 7:10 PM
nannanko accepted this revision.Sat, Apr 4, 7:12 PM
This revision is now accepted and ready to land.Sat, Apr 4, 7:12 PM
tusooa updated this revision to Diff 916.Sat, Apr 4, 7:41 PM

ref for card contentItem

Harbormaster failed remote builds in B598: Diff 916!Sat, Apr 4, 9:02 PM
Harbormaster completed remote builds in B598: Diff 916.Mon, Apr 6, 12:44 PM
Closed by commit rKf7b74071a07a: Implement SAS verification. · Explain WhyThu, Apr 9, 9:18 PM
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rKf7b74071a07a: Implement SAS verification.

Revision Contents
Changeset List

Diff 924

View Options

src/CMakeLists.txt

Loading...
View Options

src/contents/ui/Main.qml

Loading...
View Options

src/contents/ui/SasCodes.qml

Loading...
View Options

src/contents/ui/VerificationsPage.qml

Loading...
View Options

src/contents/ui/sas-emoji-defs.js

Loading...
View Options

src/js/package.json

Loading...
View Options

src/js/sas-emoji-defs.js

Loading...
View Options

src/js/scripts/update-sas-emojis.mjs

Loading...
View Options

src/l10n/cmn-Hans/100-ui.ftl

Loading...
View Options

src/l10n/en/100-ui.ftl

Loading...
View Options

src/matrix-sdk.hpp

Loading...
View Options

src/matrix-sdk.cpp

Loading...
View Options

src/matrix-verification-list.hpp

Loading...
View Options

src/matrix-verification-list.cpp

Loading...
View Options

src/matrix-verification.hpp

Loading...
View Options

src/matrix-verification.cpp

Loading...
View Options

src/tests/quick-tests/tst_VerificationsPage.qml

Loading...