Details

Reviewers

nannanko

Group Reviewers

O1: the Kazv Project

Maniphest Tasks

T156: SAS verification

Commits

rL88087cac3fb7: Implement Client integration for verification

Summary

This is part 3 of https://iron.lily-is.land/T156 . It implements an integration layer in Client for device verification. The layer handles the receiving and sending of verification events.

The unit tests in verification-processing-test.cpp are adapted from an output of OpenCode.

Type: add

Test Plan

To be tested together with the corresponding diff in kazv.

Diff Detail

Repository

rL libkazv

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tusooa created this revision.Thu, Mar 19, 8:05 PM

Owners added a reviewer: O1: the Kazv Project.Thu, Mar 19, 8:05 PM

Still work in progress. Also missing tests.

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Mar 19, 8:30 PM

Harbormaster failed remote builds in B572: Diff 887!

add EnsureKeysForDevicesAction

Harbormaster completed remote builds in B576: Diff 892.Mon, Mar 23, 7:52 PM

tusooa requested review of this revision.Mon, Mar 23, 7:52 PM

tusooa added a parent revision: D294: Add verification tracker.Mon, Mar 23, 9:25 PM

add missing implementations

Harbormaster completed remote builds in B578: Diff 894.Mon, Mar 23, 10:10 PM

add tests

style fix

tusooa edited the summary of this revision. (Show Details)Tue, Mar 24, 12:58 PM

Harbormaster failed remote builds in B579: Diff 895!Tue, Mar 24, 1:02 PM

Harbormaster failed remote builds in B580: Diff 896!

fix build

Harbormaster completed remote builds in B581: Diff 897.Tue, Mar 24, 1:35 PM

Mark devices as verified when we want to send a done event

Harbormaster failed remote builds in B584: Diff 900!Wed, Mar 25, 1:20 PM

tusooa added a task: T156: SAS verification.Fri, Mar 27, 12:46 PM

Prevent updating keys overriding trust level

Harbormaster failed remote builds in B587: Diff 903!Fri, Mar 27, 10:09 PM

tusooa added inline comments.Tue, Mar 31, 9:25 PM

src/client/client.cpp
415	every action should notify tracker change

tusooa marked an inline comment as not done.Tue, Mar 31, 9:25 PM

notify tracker model update on every change

Harbormaster completed remote builds in B592: Diff 909.Wed, Apr 1, 12:21 PM

nannanko accepted this revision.Sat, Apr 4, 7:11 PM

This revision is now accepted and ready to land.Sat, Apr 4, 7:11 PM

Closed by commit rL88087cac3fb7: Implement Client integration for verification. · Explain WhySat, Apr 4, 8:10 PM

This revision was automatically updated to reflect the committed changes.

tusooa added a commit: rL88087cac3fb7: Implement Client integration for verification.

Implement Client integration for verification
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 918

src/base/kazv-triggers.hpp

src/client/actions/encryption.hpp

src/client/actions/encryption.cpp

src/client/actions/sync.cpp

src/client/client-model.hpp

src/client/client.hpp

src/client/client.cpp

src/client/clientfwd.hpp

src/client/device-list-tracker.cpp

src/client/sdk.hpp

src/tests/CMakeLists.txt

src/tests/client/action-mock-utils.hpp

src/tests/client/encryption-test.cpp

src/tests/client/sync-test.cpp

src/tests/client/verification-processing-test.cpp

Implement Client integration for verificationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 918

src/base/kazv-triggers.hpp

src/client/actions/encryption.hpp

src/client/actions/encryption.cpp

src/client/actions/sync.cpp

src/client/client-model.hpp

src/client/client.hpp

src/client/client.cpp

src/client/clientfwd.hpp

src/client/device-list-tracker.cpp

src/client/sdk.hpp

src/tests/CMakeLists.txt

src/tests/client/action-mock-utils.hpp

src/tests/client/encryption-test.cpp

src/tests/client/sync-test.cpp

src/tests/client/verification-processing-test.cpp

Implement Client integration for verification
ClosedPublic
Actions

Revision Contents
Changeset List