Differential D282

Implement key importing
Needs ReviewPublic
Actions

Authored by tusooa on Mon, Feb 16, 7:22 AM.

Details

Reviewers

nannanko

Group Reviewers

O1: the Kazv Project

Summary

Add a UI to import E2EE keys.

BUG: https://iron.lily-is.land/T172

Type: add

Test Plan

Create a key backup file from a supported client. Go to Settings. Click "Import keys from a backup file...". Select the key file. In the next popup, enter the password. Verify you can see a passive notification "Imported N keys."

Diff Detail

Repository

rK kazv

Branch

tusooa/key-import

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 559
Build 1100: Invoke Buildbot	Buildbot build #1302
Build 1099: arc lint + arc unit

Event Timeline

tusooa created this revision.Mon, Feb 16, 7:22 AM

Owners added a reviewer: O1: the Kazv Project.Mon, Feb 16, 7:22 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Mon, Feb 16, 7:36 AM

Harbormaster failed remote builds in B543: Diff 844!

tusooa edited the summary of this revision. (Show Details)Mon, Feb 16, 8:44 AM

Harbormaster completed remote builds in B543: Diff 844.Sat, Feb 21, 6:42 PM

tusooa requested review of this revision.Sat, Feb 21, 6:42 PM

tusooa added a reviewer: nannanko.Mon, Mar 2, 11:34 AM

When I enter a wrong password, then open the input box again, the old password will still be retained. Especially when I click the "show password", the input box will retain this setting. This is obviously inconsistent with the behavior of most similar software and may lead to unexpected occurrences.

This revision is now accepted and ready to land.Thu, Mar 5, 8:49 AM

nannanko requested changes to this revision.Thu, Mar 5, 8:49 AM

This revision now requires changes to proceed.Thu, Mar 5, 8:49 AM

Clear password before showing dialog

Harbormaster completed remote builds in B559: Diff 869.Mon, Mar 9, 1:52 PM

In D282#5560, @nannanko wrote:

When I enter a wrong password, then open the input box again, the old password will still be retained. Especially when I click the "show password", the input box will retain this setting. This is obviously inconsistent with the behavior of most similar software and may lead to unexpected occurrences.

resolved, please review again, thank you!