Differential D266

Refactor podman-helper to use class
ClosedPublic
Actions

Authored by tusooa on Sat, Jan 10, 8:53 AM.

Details

Reviewers

None

Group Reviewers

O2: lilybuild

Commits

rB88a01b2aee6d: Refactor podman-helper to use class

Summary

Before, we stored everything in global variables, which makes it hard to test. This switches to a class-based approach and add some tests.

Type: skip

Test Plan

Verify current pipelines still build.

Diff Detail

Repository

rB lilybuild

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tusooa created this revision.Sat, Jan 10, 8:53 AM

Owners added a reviewer: O2: lilybuild.Sat, Jan 10, 8:53 AM

Harbormaster completed remote builds in B518: Diff 807.Sat, Jan 10, 8:56 AM

tusooa requested review of this revision.Sat, Jan 10, 8:56 AM

Add more tests

Harbormaster completed remote builds in B519: Diff 808.Sat, Jan 10, 10:30 AM

test cleanup_all

Harbormaster completed remote builds in B520: Diff 809.Sat, Jan 10, 10:36 AM

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Jan 20, 12:01 PM

Closed by commit rB88a01b2aee6d: Refactor podman-helper to use class. · Explain Why

This revision was automatically updated to reflect the committed changes.

tusooa added a commit: rB88a01b2aee6d: Refactor podman-helper to use class.

Revision Contents
Changeset List

Path

Size

Packages

lilybuild/

podman_helper.py

405 lines

O2: lilybuild

tests/

podman_helper_test_worker.py

273 lines

O2: lilybuild

podman-helper

1 line

O2: lilybuild

Diff 815

View Options

lilybuild/lilybuild/podman_helper.py

View Options

lilybuild/lilybuild/tests/podman_helper_test_worker.py

View Options

Refactor podman-helper to use classClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 815

lilybuild/lilybuild/podman_helper.py

lilybuild/lilybuild/tests/podman_helper_test_worker.py

lilybuild/podman-helper

Refactor podman-helper to use class
ClosedPublic
Actions

Revision Contents
Changeset List