Page MenuHomePhorge
Differential D261

Make EventReadIndicator scrollable
Needs ReviewPublic
Actions

Authored by nannanko on Fri, Jan 2, 7:48 PM.

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Maniphest Tasks
T169: EventReadIndicator isn't scrollable
Summary

When there are too many people in the EventReadIndicator, all of them cannot be displayed. This diff fixed it by make EventReadIndicator scrollable.

Type: fix

Test Plan

Open an EventReadIndicator with enough people, check if it can be scrolled to show everyone.

Diff Detail

Repository
rK kazv
Branch
nannanko/scrollable-event-read-indicator
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 509
Build 1000: Invoke BuildbotBuildbot build #736
Build 999: arc lint + arc unit

Event Timeline

nannanko created this revision.Fri, Jan 2, 7:48 PM
Owners added a reviewer: O1: the Kazv Project.Fri, Jan 2, 7:48 PM
Herald added a reviewer: servant. · View Herald TranscriptFri, Jan 2, 7:48 PM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Jan 2, 7:48 PM
Harbormaster failed remote builds in B509: Diff 790!
nannanko requested review of this revision.Fri, Jan 2, 7:48 PM
nannanko added a task: T169: EventReadIndicator isn't scrollable.
nannanko edited the summary of this revision. (Show Details)
nannanko removed a reviewer: servant.
nannanko updated this revision to Diff 793.Sat, Jan 3, 7:16 PM

Rebase to servant

Harbormaster completed remote builds in B512: Diff 793.Sat, Jan 3, 8:32 PM

Revision Contents
Changeset List

PathSizePackages
src/
contents/
ui/
68 linesO1: the Kazv Project

Diff 790

View Options

src/contents/ui/EventReadIndicator.qml

Loading...