Page MenuHomePhorge
Differential D250

Check rules when executing step
ClosedPublic
Actions

Authored by tusooa on Fri, Dec 5, 9:07 AM.
Tags
None
Referenced Files
F13594355: D250.1765197070.diff
Sun, Dec 7, 4:31 AM
F13594349: D250.1765197068.diff
Sun, Dec 7, 4:31 AM
F13594346: D250.1765197065.diff
Sun, Dec 7, 4:31 AM
F13590372: D250.1765191401.diff
Sun, Dec 7, 2:56 AM
F13551805: D250.1765140681.diff
Sat, Dec 6, 12:51 PM
F13551739: D250.1765140590.diff
Sat, Dec 6, 12:49 PM
F13551738: D250.1765140589.diff
Sat, Dec 6, 12:49 PM
F13551725: D250.1765140579.diff
Sat, Dec 6, 12:49 PM
Subscribers
None

Details

Reviewers
None
Group Reviewers
O2: lilybuild
Commits
rBc7d49a9424c1: Check rules when executing step
Summary

We will now check rules:if and will not execute the step if it is not meant to be run.

Type: add

Test Plan

Test it on a repo with a pipeline containing rules:if and verify it behaves as intended.

Diff Detail

Repository
rB lilybuild
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tusooa created this revision.Fri, Dec 5, 9:07 AM
Owners added a reviewer: O2: lilybuild.Fri, Dec 5, 9:07 AM
Harbormaster completed remote builds in B479: Diff 746.Fri, Dec 5, 9:09 AM
tusooa requested review of this revision.Fri, Dec 5, 9:09 AM
This revision was not accepted when it landed; it landed in state Needs Review.Fri, Dec 5, 9:58 AM
Closed by commit rBc7d49a9424c1: Check rules when executing step. · Explain Why
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rBc7d49a9424c1: Check rules when executing step.

Revision Contents
Changeset List

PathSizePackages
lilybuild/
lilybuild/
51 linesO2: lilybuild
ci_syntax/
5 linesO2: lilybuild
1 lineO2: lilybuild
tests/
ci_syntax/
4 linesO2: lilybuild
res/
15 linesO2: lilybuild

Diff 749

View Options

lilybuild/lilybuild/ci_steps.py

Loading...
View Options

lilybuild/lilybuild/ci_syntax/ci_file.py

Loading...
View Options

lilybuild/lilybuild/config.py

Loading...
View Options

lilybuild/lilybuild/tests/ci_syntax/ci_file_test.py

Loading...
View Options

lilybuild/lilybuild/tests/ci_syntax/res/variables.yaml

Loading...