Fix potential ambiguous conversion from json to optional<json>
ClosedPublic
Actions

Authored by tusooa on Tue, Sep 16, 5:37 AM.

Details

Reviewers

nannanko

Group Reviewers

O1: the Kazv Project

Commits

rL7e83b1477f89: Fix potential ambiguous conversion from json to optional<json>

Summary

Reported by @yifei:luv.asn.au on matrix. In some environments the compiler is not happy with return json(...); when the return type of the function is declared as std::optional<json>. This specifically invokes the std::optional constructor.

Type: fix

Test Plan

N/A

Diff Detail

Repository

rL libkazv

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tusooa created this revision.Tue, Sep 16, 5:37 AM

Owners added a reviewer: O1: the Kazv Project.Tue, Sep 16, 5:37 AM

Harbormaster completed remote builds in B427: Diff 680.Tue, Sep 16, 5:46 AM

tusooa requested review of this revision.Tue, Sep 16, 5:46 AM

nannanko accepted this revision.Wed, Sep 17, 5:07 PM

This revision is now accepted and ready to land.Wed, Sep 17, 5:07 PM

Closed by commit rL7e83b1477f89: Fix potential ambiguous conversion from json to optional<json>. · Explain WhyMon, Sep 29, 5:58 PM

This revision was automatically updated to reflect the committed changes.

tusooa added a commit: rL7e83b1477f89: Fix potential ambiguous conversion from json to optional<json>.

Revision Contents
Changeset List

Path

Size

Packages

src/

base/

json-utils.hpp

2 lines

O1: the Kazv Project

Diff 701

View Options

Fix potential ambiguous conversion from json to optional<json>ClosedPublicActions