Page MenuHomePhorge

Implement event editing
ClosedPublic

Authored by tusooa on May 8 2024, 6:54 PM.
Tags
None
Referenced Files
F113806: D22.1732489103.diff
Sat, Nov 23, 2:58 PM
F113699: D22.1732488679.diff
Sat, Nov 23, 2:51 PM
F113646: D22.1732488343.diff
Sat, Nov 23, 2:45 PM
Subscribers
None

Details

Summary

This adds a menu item to edit a self-sent text event. It also enables one to send an event with rel-type m.replace.

Type: add

Test Plan
  • Verify unit tests pass.

Basic editing functionality:

  • Open the menu for a self-sent text event.
  • Verify that the Edit button is enabled.
  • Click the Edit button.
  • Verify that the send message box is filled with the body of that event.
  • Input something in the send message box.
  • Send the message.
  • Verify that a local echo is displayed briefly and then the edited version is shown.

Get the correct body for a reply event:

  • Send a message replying to some other text event from Element Web.
  • Edit that message from kazv.
  • Verify that the send message box is only filled with the actual content, not the quotation.

Edit an edited event:

  • Edit an edited event.
  • Verify that the body of the newest is in the send message box.

Reply functionality:

  • Reply to an event in kazv.
  • Verify that the reply can be successfully sent.

Cancelling relationships:

  • In the event menu click on Reply.
  • Click the (x) button on the top-right of the send message box.
  • Verify that the replied-to event is no longer displayed on the top.
  • In the event menu click on Edit.
  • Click the (x) button on the top-right of the send message box.
  • Verify that the event being edited is no longer displayed on the top.
  • Verify that the send message box still contains whatever it contained before clicking (x).

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.May 8 2024, 6:57 PM
Harbormaster failed remote builds in B36: Diff 49!
This revision is now accepted and ready to land.Jun 1 2024, 2:30 AM
This revision was automatically updated to reflect the committed changes.