Page MenuHomePhorge
Differential D215

Add kazv-io-manager-test.cpp
ClosedPublic
Actions

Authored by nannanko on Sat, May 24, 6:21 PM.

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Maniphest Tasks
T114: Add tests for kazv-io-manager and kazv-io-job
Commits
rK73a8eba421e6: Add kazv-io-manager-test.cpp
Summary

Add test for KazvIOManager

Type: skip

Test Plan

Verify unit tests pass.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nannanko created this revision.Sat, May 24, 6:21 PM
Owners added a reviewer: O1: the Kazv Project.Sat, May 24, 6:21 PM
Herald added a reviewer: servant. · View Herald TranscriptSat, May 24, 6:21 PM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

nannanko edited the summary of this revision. (Show Details)Sat, May 24, 6:22 PM
nannanko removed a reviewer: servant.
Harbormaster completed remote builds in B369: Diff 603.Sat, May 24, 6:40 PM
nannanko requested review of this revision.Sat, May 24, 6:40 PM
nannanko added a task: T114: Add tests for kazv-io-manager and kazv-io-job.Sun, May 25, 9:24 AM
tusooa requested changes to this revision.Sat, Jun 7, 6:12 PM
tusooa added inline comments.
src/tests/kazv-io-manager-test.cpp
37–39

they should be static globals

This revision now requires changes to proceed.Sat, Jun 7, 6:12 PM
nannanko updated this revision to Diff 621.Sat, Jun 7, 7:25 PM

Make const variables static global

nannanko marked an inline comment as done.Sat, Jun 7, 7:25 PM
Harbormaster completed remote builds in B383: Diff 621.Sat, Jun 7, 7:41 PM
tusooa accepted this revision.Wed, Jun 18, 4:28 PM
This revision is now accepted and ready to land.Wed, Jun 18, 4:28 PM
Closed by commit rK73a8eba421e6: Add kazv-io-manager-test.cpp. · Explain WhySat, Jun 21, 7:08 PM
This revision was automatically updated to reflect the committed changes.
nannanko added a commit: rK73a8eba421e6: Add kazv-io-manager-test.cpp.

Revision Contents
Changeset List

Diff 630

View Options

src/tests/CMakeLists.txt

Loading...
View Options

src/tests/kazv-io-manager-test.cpp

Loading...