Page MenuHomePhorge
Differential D210

Add kazv-io-job-test
Changes PlannedPublic
Actions

Authored by nannanko on Fri, Mar 14, 6:04 AM.
Tags
None
Referenced Files
F194844: D210.1743772066.diff
Thu, Apr 3, 6:07 AM
F194843: D210.1743772063.diff
Thu, Apr 3, 6:07 AM
F194842: D210.1743772057.diff
Thu, Apr 3, 6:07 AM
F194841: D210.1743772049.diff
Thu, Apr 3, 6:07 AM
F194769: D210.1743754905.diff
Thu, Apr 3, 1:21 AM
F194748: D210.1743741695.diff
Wed, Apr 2, 9:41 PM
F194746: D210.1743741692.diff
Wed, Apr 2, 9:41 PM
F194745: D210.1743741691.diff
Wed, Apr 2, 9:41 PM
View All 9 Files
Subscribers
None

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Maniphest Tasks
T114: Add tests for kazv-io-manager and kazv-io-job
Summary

Add tests for kazv-io-job.cpp

Type: skip

Test Plan

Verify unit tests pass.

Diff Detail

Repository
rK kazv
Branch
nannanko/kazv-io-test
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 341
Build 665: GitLab CI for kazv
Build 664: arc lint + arc unit

Event Timeline

nannanko created this revision.Fri, Mar 14, 6:04 AM
Owners added a reviewer: O1: the Kazv Project.Fri, Mar 14, 6:04 AM
nannanko added a task: T114: Add tests for kazv-io-manager and kazv-io-job.Fri, Mar 14, 6:11 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Mar 14, 6:17 AM
Harbormaster failed remote builds in B337: Diff 557!
nannanko updated this revision to Diff 558.Fri, Mar 14, 10:31 PM

Fix code for libhttpserver 0.18.2

Harbormaster completed remote builds in B338: Diff 558.Fri, Mar 14, 10:45 PM
nannanko requested review of this revision.Fri, Mar 14, 10:45 PM
nannanko planned changes to this revision.Fri, Mar 14, 11:22 PM
tusooa requested changes to this revision.Sat, Mar 15, 5:56 PM
tusooa added inline comments.
CMakeLists.txt
81
src/tests/CMakeLists.txt
36

Use the PkgConfig::libhttpserver target, because it also includes the include dirs of that target. Also, use ecm_add_test to single out this one test that requires extra link libraries.

src/tests/kazv-io-job-test.cpp
62–66

This suffers from time-of-check, time-of-use problem. By the time the port is closed, it may no longer be free.

nannanko updated this revision to Diff 559.Fri, Mar 21, 6:55 PM

Use PkgConfig correctly, fixed time-of-check, time-of-use problem for port.

nannanko planned changes to this revision.Fri, Mar 21, 6:55 PM
nannanko marked 3 inline comments as done.
Harbormaster completed remote builds in B339: Diff 559.Fri, Mar 21, 7:09 PM
nannanko updated this revision to Diff 560.Sat, Mar 29, 8:06 PM

Use QHttpServer instead of libhttpserver, and add upload test.

nannanko planned changes to this revision.Sat, Mar 29, 8:06 PM
nannanko updated this revision to Diff 561.Wed, Apr 2, 4:45 AM

Add test about pause among downloading.

nannanko planned changes to this revision.Wed, Apr 2, 4:45 AM
nannanko updated this revision to Diff 562.Wed, Apr 2, 5:28 AM

Add test for cancel download.

nannanko updated this revision to Diff 564.Wed, Apr 2, 5:30 AM

Upgrade the required Qt version to 6.8

nannanko planned changes to this revision.Wed, Apr 2, 5:30 AM
nannanko updated this revision to Diff 565.Wed, Apr 2, 5:44 AM

Add test for KazvIODownloadJob::fileName and KazvIOUploadJob::fileName

nannanko planned changes to this revision.Wed, Apr 2, 5:44 AM

Revision Contents
Changeset List

Diff 561

View Options

CMakeLists.txt

Loading...
View Options

src/tests/CMakeLists.txt

Loading...
View Options

src/tests/kazv-io-job-test.cpp

Loading...