Page MenuHomePhorge

Add kazv-io-job-test
Changes PlannedPublic

Authored by nannanko on Fri, Mar 14, 6:04 AM.

Details

Summary

Add tests for kazv-io-job.cpp

Type: skip

Test Plan

Verify unit tests pass.

Diff Detail

Repository
rK kazv
Branch
nannanko/kazv-io-test
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 340
Build 663: GitLab CI for kazv
Build 662: arc lint + arc unit

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Mar 14, 6:17 AM
Harbormaster failed remote builds in B337: Diff 557!

Fix code for libhttpserver 0.18.2

tusooa requested changes to this revision.Sat, Mar 15, 5:56 PM
tusooa added inline comments.
CMakeLists.txt
81
src/tests/CMakeLists.txt
36

Use the PkgConfig::libhttpserver target, because it also includes the include dirs of that target. Also, use ecm_add_test to single out this one test that requires extra link libraries.

src/tests/kazv-io-job-test.cpp
62–66

This suffers from time-of-check, time-of-use problem. By the time the port is closed, it may no longer be free.

Use PkgConfig correctly, fixed time-of-check, time-of-use problem for port.

nannanko marked 3 inline comments as done.

Use QHttpServer instead of libhttpserver, and add upload test.