Add tests for kazv-io-job.cpp
Type: skip
Details
Details
- Reviewers
tusooa - Group Reviewers
O1: the Kazv Project - Maniphest Tasks
- T114: Add tests for kazv-io-manager and kazv-io-job
Verify unit tests pass.
Diff Detail
Diff Detail
- Repository
- rK kazv
- Branch
- nannanko/kazv-io-test
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 367 Build 717: GitLab CI for kazv Build 716: arc lint + arc unit
Event Timeline
| CMakeLists.txt | ||
|---|---|---|
| 81 | ||
| src/tests/CMakeLists.txt | ||
| 36 | Use the PkgConfig::libhttpserver target, because it also includes the include dirs of that target. Also, use ecm_add_test to single out this one test that requires extra link libraries. | |
| src/tests/kazv-io-job-test.cpp | ||
| 62–66 | This suffers from time-of-check, time-of-use problem. By the time the port is closed, it may no longer be free. | |
Comment Actions
I don't know how to implement testUploadPause and testUploadCancel. All other than that have been completed.
Comment Actions
I don't know how to implement testUploadPause and testUploadCancel. All other than that have been completed.
| src/kazv-file.cpp | ||
|---|---|---|
| 20–21 | ||
| src/kazv-io-job.cpp | ||
| 246 | ||
| src/tests/kazv-io-job-test.cpp | ||
| 88–92 | Instead of repeatedly using #if, we better use it only once: #if ...
using QHttpServerResponderRef = QHttpServerResponder &&;
#else
using QHttpServerResponderRef = QHttpServerResponder &;
#endifand then use QHttpServerResponderRef as the argument type. Also, don't forget to include comments to indicate why it is necessary to do so. | |