Page MenuHomePhorge

Add indicator for tombstoned room
Needs RevisionPublic

Authored by nannanko on Sat, Nov 2, 8:20 PM.
Tags
None
Referenced Files
F106352: D197.1730789687.diff
Sun, Nov 3, 10:54 PM
F106282: D197.1730778591.diff
Sun, Nov 3, 7:49 PM
F106280: D197.1730778569.diff
Sun, Nov 3, 7:49 PM
F106143: D197.1730762588.diff
Sun, Nov 3, 3:23 PM
Subscribers
None

Details

Summary

Add indicator for tombstoned room.

Type: add

Test Plan

Verify unit tests passes.

Diff Detail

Repository
rK kazv
Branch
nannanko/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 315
Build 618: GitLab CI for kazv
Build 617: arc lint + arc unit

Event Timeline

tusooa requested changes to this revision.Sat, Nov 2, 9:19 PM
tusooa added inline comments.
src/matrix-room.cpp
77–80

We can use string literals (""s https://en.cppreference.com/w/cpp/string/basic_string/operator%22%22s ) to make it more concise.

.make() should be unnecessary, and you can use .map() instead of .xform(zug::map()).

This revision now requires changes to proceed.Sat, Nov 2, 9:19 PM
tusooa requested changes to this revision.Sun, Nov 3, 7:08 AM
tusooa added inline comments.
src/matrix-room.cpp
31

Include std headers right after <kazv-defs.hpp>

This revision now requires changes to proceed.Sun, Nov 3, 7:08 AM