Differential D136

Fix file name not being displayed in ConfirmUploadPopup
ClosedPublic
Actions

Authored by tusooa on Jul 16 2024, 6:59 PM.

Details

Reviewers

nannanko

Group Reviewers

O1: the Kazv Project

Commits

rK7cd7b896c6c7: Fix file name not being displayed in ConfirmUploadPopup

Summary

Qt 6's url type is no longer auto-convertible to strings. This uses the URL constructor as per https://doc.qt.io/qt-6/qml-url.html#details .

Type: fix

Test Plan

Drop some file into a SendMessageBox. Verify it displays the correct file name.

Diff Detail

Repository

rK kazv

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tusooa created this revision.Jul 16 2024, 6:59 PM

Owners added a reviewer: O1: the Kazv Project.Jul 16 2024, 6:59 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 16 2024, 7:04 PM

Harbormaster failed remote builds in B198: Diff 322!

Harbormaster completed remote builds in B198: Diff 322.Jul 19 2024, 7:54 PM

tusooa requested review of this revision.Jul 19 2024, 7:54 PM

nannanko accepted this revision.Jul 23 2024, 11:58 PM

This revision is now accepted and ready to land.Jul 23 2024, 11:58 PM

Closed by commit rK7cd7b896c6c7: Fix file name not being displayed in ConfirmUploadPopup. · Explain WhyJul 24 2024, 2:34 PM

This revision was automatically updated to reflect the committed changes.

tusooa added a commit: rK7cd7b896c6c7: Fix file name not being displayed in ConfirmUploadPopup.

Revision Contents
Changeset List

Path

Size

Packages

src/

contents/

ui/

ConfirmUploadPopup.qml

2 lines

O1: the Kazv Project

Diff 370

View Options

src/contents/ui/ConfirmUploadPopup.qml

Fix file name not being displayed in ConfirmUploadPopupClosedPublicActions