Page MenuHomePhorge
Differential D133

Compile qml files into module
ClosedPublic
Actions

Authored by tusooa on Jul 14 2024, 4:31 PM.
Tags
None
Referenced Files
F6638560: D133.1755621578.diff
Mon, Aug 18, 9:39 AM
F6633438: D133.1755617026.diff
Mon, Aug 18, 8:23 AM
F6626306: D133.1755612975.diff
Mon, Aug 18, 7:16 AM
F6625432: D133.1755611380.diff
Mon, Aug 18, 6:49 AM
F6526685: D133.1755553711.diff
Sun, Aug 17, 2:48 PM
Subscribers
None

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Commits
rK9ea468640279: Compile qml files into module
Summary

This uses the method recommended by Kirigami docs ( https://develop.kde.org/docs/getting-started/kirigami/introduction-getting_started/ ) to load qml files.

Type: skip

BUG: https://iron.lily-is.land/T111

Test Plan

Verify all unit tests pass. Verify kazv still works.

Diff Detail

Repository
rK kazv
Branch
tusooa/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 194
Build 377: GitLab CI for kazv
Build 376: arc lint + arc unit

Event Timeline

tusooa created this revision.Jul 14 2024, 4:31 PM
Owners added a reviewer: O1: the Kazv Project.Jul 14 2024, 4:31 PM
tusooa edited the summary of this revision. (Show Details)Jul 14 2024, 4:31 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 14 2024, 4:36 PM
Harbormaster failed remote builds in B194: Diff 318!
Harbormaster completed remote builds in B194: Diff 318.Jul 19 2024, 7:45 PM
tusooa requested review of this revision.Jul 19 2024, 7:45 PM
nannanko accepted this revision.Jul 23 2024, 11:50 PM
This revision is now accepted and ready to land.Jul 23 2024, 11:50 PM
Closed by commit rK9ea468640279: Compile qml files into module. · Explain WhyJul 24 2024, 2:34 PM
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rK9ea468640279: Compile qml files into module.

Revision Contents
Changeset List

Diff 318

View Options

src/CMakeLists.txt

Loading...
View Options

src/contents/ui/Bubble.qml

Loading...
View Options

src/contents/ui/Main.qml

Loading...
View Options

src/contents/ui/event-types/Simple.qml

Loading...
View Options

src/contents/ui/main.qml

Loading...
View Options

src/contents/ui/room-settings/RoomSettingsPage.qml

Loading...
View Options

src/kazv-io-job.hpp

Loading...
View Options

src/main.cpp

Loading...
View Options

src/resources.qrc

Loading...
View Options

src/tests/quick-tests/tst_EventView.qml

Loading...