Page MenuHomePhorge
Differential D131

Implement pinning and unpinning events
ClosedPublic
Actions

Authored by tusooa on Jul 14 2024, 10:16 AM.

Details

Reviewers
nannanko
Group Reviewers
O1: the Kazv Project
Commits
rK31da53994d15: Implement pinning and unpinning events
Summary

This commit implements pinning and unpinning events.

Type: add

Depends-on: https://iron.lily-is.land/D130

BUG: https://iron.lily-is.land/T90

Test Plan

Verify that you can pin messages in the room timeline. Verify that you can unpin messages in both the room timeline and the pinned events timeline.

Diff Detail

Repository
rK kazv
Branch
tusooa/pin-unpin
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 195
Build 379: GitLab CI for kazv
Build 378: arc lint + arc unit

Event Timeline

tusooa created this revision.Jul 14 2024, 10:16 AM
Owners added a reviewer: O1: the Kazv Project.Jul 14 2024, 10:16 AM
Herald added a reviewer: servant. · View Herald TranscriptJul 14 2024, 10:16 AM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

tusooa edited the summary of this revision. (Show Details)Jul 14 2024, 10:17 AM
tusooa removed a reviewer: servant.
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 14 2024, 10:34 AM
Harbormaster failed remote builds in B192: Diff 316!
tusooa added a comment.Jul 14 2024, 2:27 PM

add a reminder to myself to remove extra logging

src/contents/ui/Bubble.qml
25–26

remove this

tusooa updated this revision to Diff 319.Jul 14 2024, 8:03 PM

Remove debugging statements

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 14 2024, 8:09 PM
Harbormaster failed remote builds in B195: Diff 319!
tusooa mentioned this in D125: Add confirm popup for delete event.Jul 17 2024, 5:09 PM
tusooa added parent revisions: D129: Support displaying pinned events, D130: Add Room::pinEvents() and Room::unpinEvents().Jul 17 2024, 10:00 PM
Harbormaster completed remote builds in B195: Diff 319.Jul 19 2024, 3:57 PM
tusooa requested review of this revision.Jul 19 2024, 3:57 PM
nannanko accepted this revision.Jul 20 2024, 5:38 AM
This revision is now accepted and ready to land.Jul 20 2024, 5:38 AM
Closed by commit rK31da53994d15: Implement pinning and unpinning events. · Explain WhyJul 21 2024, 8:26 AM
This revision was automatically updated to reflect the committed changes.
tusooa added a commit: rK31da53994d15: Implement pinning and unpinning events.

Revision Contents
Changeset List

Diff 319

View Options

src/CMakeLists.txt

Loading...
View Options

src/contents/ui/Bubble.qml

Loading...
View Options

src/contents/ui/ConfirmationOverlay.qml

Loading...
View Options

src/contents/ui/RoomPinnedEventsPage.qml

Loading...
View Options

src/contents/ui/RoomTimelineView.qml

Loading...
View Options

src/l10n/cmn-Hans/100-ui.ftl

Loading...
View Options

src/l10n/en/100-ui.ftl

Loading...
View Options

src/matrix-room-pinned-events-timeline.hpp

Loading...
View Options

src/matrix-room-pinned-events-timeline.cpp

Loading...
View Options

src/matrix-room.hpp

Loading...
View Options

src/matrix-room.cpp

Loading...
View Options

src/tests/quick-tests/tst_EventView.qml

Loading...
View Options

src/tests/quick-tests/tst_RoomTimelineView.qml

Loading...