Page MenuHomePhorge

Make the resend button a ToolButton
ClosedPublic

Authored by nannanko on Jul 13 2024, 6:36 AM.
Tags
None
Referenced Files
F38465: D122.1728090416.diff
Thu, Oct 3, 6:06 PM
F38429: D122.1728071360.diff
Thu, Oct 3, 12:49 PM
F38084: D122.1728011612.diff
Wed, Oct 2, 8:13 PM
Unknown Object (File)
Wed, Oct 2, 6:24 PM
Unknown Object (File)
Wed, Oct 2, 6:23 PM
Unknown Object (File)
Wed, Oct 2, 6:22 PM
Unknown Object (File)
Wed, Oct 2, 6:21 PM
Unknown Object (File)
Sat, Sep 28, 11:29 PM
Subscribers
None

Details

Summary

"Unable to send" indicator is not obvious that it is clickable, This revision make it a ToolButton.

Type: fix

Test Plan

Make a local echo event.
Verify that the button appears with a border when the mouse is hovered.
Verify that the message is resent when the button is clicked.

Diff Detail

Repository
rK kazv
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 13 2024, 6:52 AM
Harbormaster failed remote builds in B172: Diff 291!

Fix tests for resent button

tusooa requested changes to this revision.Jul 13 2024, 8:04 AM

You chose the wrong base in the second version.

This revision now requires changes to proceed.Jul 13 2024, 8:04 AM
src/contents/ui/Bubble.qml
194

Which means it would be a ToolButton even when it's sending

208–211

A button no longer need a TapHandler, just use the button's onClicked signal handler

Make the resend button a ToolButton

nannanko removed a reviewer: servant.

Make the resend button a ToolButton

Fix test for resend button

Make the resend button a ToolButton

This revision is now accepted and ready to land.Jul 18 2024, 11:30 PM
This revision was automatically updated to reflect the committed changes.