Details

Reviewers

None

Group Reviewers

O1: the Kazv Project

Summary

MatrixSdk is now separated into 3 different classes:

MatrixSdk, the entrypoint that controls listing and deleting sessions; it also handles MatrixSessionController
MatrixSessionController, which controls the loading and saving of one single session
MatrixSession, which controls things performed inside a session (login, sync, sending messages, etc.)

This should make tests easier and simplify logic.

Type: skip

BUG: https://iron.lily-is.land/T173

Test Plan

Check that kazv behaves exactly the same as before. Most importantly:

Check login and switching session works.
Check that the client state is saved over time, before switching sessions, and on window closing
Check past events are saved to DbStore, both in new sessions and loaded sessions

Diff Detail

Repository

rK kazv

Branch

tusooa/stacked

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 633
Build 1248: Invoke Buildbot	Buildbot build #1874
Build 1247: arc lint + arc unit

Event Timeline

tusooa created this revision.Thu, Jun 18, 8:56 PM

Owners added a reviewer: O1: the Kazv Project.Thu, Jun 18, 8:56 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Jun 18, 9:38 PM

Harbormaster failed remote builds in B633: Diff 976!

Implement session controller logic

Harbormaster returned this revision to the author for changes because remote builds failed.Sat, Jun 20, 9:53 AM

Harbormaster failed remote builds in B636: Diff 979!

Update MatrixSdk logic

Harbormaster returned this revision to the author for changes because remote builds failed.Mon, Jun 22, 9:36 PM

Harbormaster failed remote builds in B639: Diff 982!

Update qmls and fix most tests

Fix more tests

tusooa edited the test plan for this revision. (Show Details)Tue, Jun 23, 10:48 PM

Harbormaster failed remote builds in B640: Diff 983!Tue, Jun 23, 11:01 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Jun 23, 11:45 PM

Harbormaster failed remote builds in B641: Diff 984!

tusooa edited the test plan for this revision. (Show Details)Wed, Jun 24, 8:47 AM

Fix session switching and saving

Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Jun 24, 10:08 AM

Harbormaster failed remote builds in B643: Diff 986!

Fix tests

Remove unused MatrixSdk::trigger()

Harbormaster failed remote builds in B644: Diff 987!Wed, Jun 24, 11:14 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Jun 24, 11:58 AM

Harbormaster failed remote builds in B645: Diff 988!

Split MatrixSdk
Changes PlannedPublicDraft
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 976

src/CMakeLists.txt

src/db-store.hpp

src/helper.hpp

src/matrix-sdk.hpp

src/matrix-sdk.cpp

src/matrix-session-controller-p.hpp

src/matrix-session-controller.hpp

src/matrix-session-controller.cpp

src/matrix-session-types.hpp

src/matrix-session.hpp

src/matrix-session.cpp

src/tests/CMakeLists.txt

src/tests/kazv-io-manager-test.cpp

src/tests/matrix-event-test.cpp

src/tests/matrix-room-list-test.cpp

src/tests/matrix-room-state-test.cpp

src/tests/matrix-room-timeline-benchmark-test.cpp

src/tests/matrix-room-timeline-test.cpp

src/tests/matrix-sdk-sessions-test.cpp

src/tests/matrix-sdk-test.cpp

src/tests/matrix-session-test.cpp

src/tests/matrix-sticker-pack-test.cpp

src/tests/test-model.hpp

src/tests/test-model.cpp

Split MatrixSdkChanges PlannedPublicDraftActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 976

src/CMakeLists.txt

src/db-store.hpp

src/helper.hpp

src/matrix-sdk.hpp

src/matrix-sdk.cpp

src/matrix-session-controller-p.hpp

src/matrix-session-controller.hpp

src/matrix-session-controller.cpp

src/matrix-session-types.hpp

src/matrix-session.hpp

src/matrix-session.cpp

src/tests/CMakeLists.txt

src/tests/kazv-io-manager-test.cpp

src/tests/matrix-event-test.cpp

src/tests/matrix-room-list-test.cpp

src/tests/matrix-room-state-test.cpp

src/tests/matrix-room-timeline-benchmark-test.cpp

src/tests/matrix-room-timeline-test.cpp

src/tests/matrix-sdk-sessions-test.cpp

src/tests/matrix-sdk-test.cpp

src/tests/matrix-session-test.cpp

src/tests/matrix-sticker-pack-test.cpp

src/tests/test-model.hpp

src/tests/test-model.cpp

Split MatrixSdk
Changes PlannedPublicDraft
Actions

Revision Contents
Changeset List