Details
- Reviewers
tusooa - Group Reviewers
O1: the Kazv Project - Maniphest Tasks
- T167: Restore user's draft
- Commits
- rK189308838353: Restore draft after editing
Type some draft in a room, then edit a event, check if old draft is restored when exit editing.
Continuously select multiple events for editing, check if initial draft is restored when exit all editing. Additionally, all drafts that are asked to be saved will be saved and popped up in sequence.
When you have a draft and are ready to edit an event, you will be asked to confirm whether to save the draft. When you edit an event but do not send it, you will be asked to confirm whether to discard the draft.
Try switching rooms or reopening kazv, and verify it wroks fine.
Verify unit tests pass.
Diff Detail
- Repository
- rK kazv
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/tests/quick-tests/tst_SendMessageBoxDrafts.qml | ||
|---|---|---|
| 192 | I don't know why, the test_saveDraftsOnSwitching() doesn't pass without this line. | |
Currently Kazv cannot remember a room is in the state of editing or replying to an event, which makes restoring a draft difficult to achieve. I think this feture should be divided into several diffs instead of being completed in one diff.
then you can develop more diffs on top of this. once they are all ready, we can land them together.
| src/contents/ui/TribleButtonOverlay.qml | ||
|---|---|---|
| 16–21 ↗ | (On Diff #944) | Use "accept/reject/noop" instead of "left/middle/right." This makes things clearer and developers will not need to worry about where exactly the buttons are, they only need to think about semantics. |