This displays invited room at the top of room list, sorted by time.
Type: add
Details
Details
- Reviewers
tusooa - Group Reviewers
O1: the Kazv Project - Commits
- rK4dcc5526cef1: Display invited room at the top of RoomListView
- Verify unit tests pass.
- Invite user to a room
- Open kazv and verify this room at the top of room list
- Send some message in other room
- Verify the invited room is still at the top
Diff Detail
Diff Detail
- Repository
- rK kazv
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Please add a changelog type to the summary, using the following format:
Type: (add|remove|skip|security|fix)
| src/matrix-room-list.cpp | ||
|---|---|---|
| 135–157 | Why don't we just sort by membership first and timestamp second? The comparison function of the sort can be: auto aIsInvite = a.membership == Invite;
auto bIsInvite = b.membership == Invite;
if (aIsInvite != bIsInvite) {
return aIsInvite; // if my membership in A is invite, then the membership in B is not invite, so A should come first; otherwise B should come first
}
// otherwise compare by timestamp | |
Comment Actions
Add a unit test (src/tests/matrix-room-list-test.cpp) to verify that invited rooms are indeed displayed before joined rooms.