Page MenuHomePhorge
Differential D290

Enable open cached file in external application
ClosedPublic
Actions

Authored by nannanko on Sat, Mar 7, 9:44 AM.

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Commits
rKe8424b1449af: Enable open cached file in external application
Summary

The file will be cached and then open it with default application(if exists).

Type: add

Test Plan

Open a timeline with a file event, click view in menu, and check if it is opened(There may be some delays).

Diff Detail

Repository
rK kazv
Branch
nannanko/open-file-external
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 558
Build 1098: Invoke BuildbotBuildbot build #1279
Build 1097: arc lint + arc unit

Event Timeline

nannanko created this revision.Sat, Mar 7, 9:44 AM
Owners added a reviewer: O1: the Kazv Project.Sat, Mar 7, 9:44 AM
Herald added a reviewer: servant. · View Herald TranscriptSat, Mar 7, 9:44 AM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

nannanko edited the summary of this revision. (Show Details)Sat, Mar 7, 9:45 AM
nannanko removed a reviewer: servant.
Harbormaster completed remote builds in B557: Diff 867.Sat, Mar 7, 10:12 AM
nannanko requested review of this revision.Sat, Mar 7, 10:12 AM
nannanko planned changes to this revision.Sat, Mar 7, 6:17 PM
nannanko updated this revision to Diff 868.Sat, Mar 7, 6:23 PM

Open file when cache success

nannanko planned changes to this revision.Sat, Mar 7, 6:29 PM
Harbormaster completed remote builds in B558: Diff 868.Sat, Mar 7, 6:51 PM
tusooa requested changes to this revision.Mon, Mar 9, 6:10 PM
tusooa added inline comments.
src/contents/ui/MediaFileMenu.qml
40

add an error message when the cache failed

nannanko updated this revision to Diff 878.Sat, Mar 14, 5:23 AM

Show failure message

nannanko marked an inline comment as done.Sat, Mar 14, 5:23 AM
Harbormaster completed remote builds in B565: Diff 878.Sat, Mar 14, 5:49 AM
tusooa requested changes to this revision.Sat, Mar 14, 7:51 PM
tusooa added inline comments.
src/contents/ui/MediaFileMenu.qml
36–42

Delegate this to RoomTimelineView or something more persistent. Otherwise, if the EventView is deleted and re-created, then we will not be able to keep this connection.

This revision now requires changes to proceed.Sat, Mar 14, 7:51 PM
nannanko updated this revision to Diff 889.Sat, Mar 21, 8:16 AM

Connect the function that opens the file to the KazvIOJob instead of the FileHandler that can be destroyed at any time.

nannanko marked an inline comment as done.Sat, Mar 21, 8:17 AM
Harbormaster failed remote builds in B573: Diff 889!Sat, Mar 21, 8:38 AM
nannanko planned changes to this revision.Sat, Mar 21, 7:10 PM
nannanko updated this revision to Diff 890.Sat, Mar 21, 7:46 PM

autoCache will not be modified

Harbormaster failed remote builds in B574: Diff 890!Sat, Mar 21, 8:10 PM
tusooa accepted this revision.Fri, Mar 27, 9:33 AM
This revision is now accepted and ready to land.Fri, Mar 27, 9:33 AM
This revision was landed with ongoing or failed builds.Sat, Mar 28, 8:29 AM
Closed by commit rKe8424b1449af: Enable open cached file in external application. · Explain Why
This revision was automatically updated to reflect the committed changes.
nannanko added a commit: rKe8424b1449af: Enable open cached file in external application.

Revision Contents
Changeset List

Diff 868

View Options

src/contents/ui/FileHandler.qml

Loading...
View Options

src/contents/ui/MediaFileMenu.qml

Loading...