Page MenuHomePhorge

[Breaking] Remove legacy trigger types
Needs ReviewPublic

Authored by tusooa on Mon, Feb 16, 8:49 AM.

Details

Reviewers
None
Group Reviewers
O1: the Kazv Project
Summary

Originally these types were added to notify callers of actions that it has been completed. Since we added the Promise-based store, this is no longer needed because callers can directly use then() to get the result of a dispatch. This is a better method than the original one, and no new trigger classes are added since then. However, the old ones remained. Now it is time to remove this legacy.

Also, the header kazvevents.hpp is renamed to kazv-triggers.hpp , and the types KazvEvent and KazvEventList are renamed KazvTrigger and KazvTriggerList to avoid confusion from the Event class, which represents a matrix event. Old names are kept as aliases to reduce incompatibility with older code.

Type: remove

Test Plan

Verify you can build and run kazv from this commit.

Diff Detail

Repository
rL libkazv
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 544
Build 1070: Invoke BuildbotBuildbot build #1158
Build 1069: arc lint + arc unit