Page MenuHomePhorge
Differential D232

Let Filehandler react to eventContent modification
ClosedPublic
Actions

Authored by nannanko on Sep 18 2025, 6:32 AM.
Tags
None
Referenced Files
F29385306: D232.1767998800.diff
Thu, Jan 8, 2:46 PM
F29207776: D232.1767965506.diff
Thu, Jan 8, 5:31 AM
F29166197: D232.1767957578.diff
Thu, Jan 8, 3:19 AM
F29128835: D232.1767950301.diff
Thu, Jan 8, 1:18 AM
Subscribers
None

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Maniphest Tasks
T152: FileHandler is not reactive against change in the mxc uri
Commits
rK57ef15344f92: Let Filehandler react to eventContent modification
Summary

Now FileHandler.qml can react to eventContent modification.

Type: fix

Test Plan

Varify unit tests pass.

Diff Detail

Repository
rK kazv
Branch
nannanko/filehandler-eventcontent-change
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 510
Build 1002: Invoke BuildbotBuildbot build #737
Build 1001: arc lint + arc unit

Event Timeline

nannanko created this revision.Sep 18 2025, 6:32 AM
Owners added a reviewer: O1: the Kazv Project.Sep 18 2025, 6:32 AM
Herald added a reviewer: servant. · View Herald TranscriptSep 18 2025, 6:32 AM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

nannanko edited the summary of this revision. (Show Details)Sep 18 2025, 6:32 AM
nannanko removed a reviewer: servant.
nannanko added a task: T152: FileHandler is not reactive against change in the mxc uri.Sep 18 2025, 6:35 AM
Harbormaster completed remote builds in B428: Diff 681.Sep 18 2025, 6:45 AM
nannanko requested review of this revision.Sep 18 2025, 6:45 AM
nannanko updated this revision to Diff 682.Sep 18 2025, 4:23 PM

Delete useless code.

Harbormaster completed remote builds in B429: Diff 682.Sep 18 2025, 4:37 PM
nannanko mentioned this in T152: FileHandler is not reactive against change in the mxc uri.Sep 18 2025, 11:46 PM
tusooa added a comment.Sep 20 2025, 7:19 PM

mxcUri, sha256, key, iv can be combined into one object.

properties can be turned into a helper function that returns the object.

nannanko updated this revision to Diff 687.Sep 22 2025, 6:55 AM

Use helper function instead of useless properties

Harbormaster completed remote builds in B434: Diff 687.Sep 22 2025, 7:08 AM
tusooa requested changes to this revision.Sep 27 2025, 6:58 PM
tusooa added inline comments.
src/contents/ui/FileHandler.qml
71
148–151

mediaId property has been removed, I don't think it can still be accessed

This revision now requires changes to proceed.Sep 27 2025, 6:58 PM
tusooa retitled this revision from Let Filehandler react to eventCnotent modification to Let Filehandler react to eventContent modification.Oct 4 2025, 7:02 PM
nannanko updated this revision to Diff 727.Oct 11 2025, 7:05 PM

Fixed incorrect use of mediaId, add test for auto track downloading job.

Harbormaster completed remote builds in B466: Diff 727.Oct 11 2025, 7:27 PM
nannanko updated this revision to Diff 782.Sat, Dec 27, 7:10 PM
nannanko marked 2 inline comments as done.

Rebase to servant

Harbormaster failed remote builds in B505: Diff 782!Sat, Dec 27, 7:10 PM
nannanko updated this revision to Diff 791.Sat, Jan 3, 6:18 PM

Rebase to servant

Harbormaster completed remote builds in B510: Diff 791.Sat, Jan 3, 7:08 PM
tusooa accepted this revision.Tue, Jan 6, 9:15 PM
This revision is now accepted and ready to land.Tue, Jan 6, 9:15 PM
Closed by commit rK57ef15344f92: Let Filehandler react to eventContent modification. · Explain WhyWed, Jan 7, 4:06 AM
This revision was automatically updated to reflect the committed changes.
nannanko added a commit: rK57ef15344f92: Let Filehandler react to eventContent modification.

Revision Contents
Changeset List

Diff 791

View Options

src/contents/ui/FileHandler.qml

Loading...
View Options

src/contents/ui/event-types/Image.qml

Loading...
View Options

src/contents/ui/event-types/MediaBubble.qml

Loading...
View Options

src/tests/quick-tests/test-helpers/KazvIOJobMock.qml

Loading...
View Options

src/tests/quick-tests/test-helpers/KazvIOManagerMock.qml

Loading...
View Options

src/tests/quick-tests/tst_FileHandler.qml

Loading...