Page MenuHomePhorge

Stop click leaking from sticker picker
ClosedPublic

Authored by tusooa on May 19 2024, 11:10 AM.
Tags
None
Referenced Files
F2595594: D29.1751271710.diff
Sun, Jun 29, 1:21 AM
F2595108: D29.1751244265.diff
Sat, Jun 28, 5:44 PM
F2594151: D29.1751205290.diff
Sat, Jun 28, 6:54 AM
F2592952: D29.1751190910.diff
Sat, Jun 28, 2:55 AM
Subscribers
None

Details

Summary

The current use of TapHandler will leak the click event to the ones beneath them. This can cause, say a username to be clicked on when the user is picking a sticker, leading to an unwanted mention being triggered. MouseArea does not suffer from the same problem as TapHandler, and it is able to handle touch events as well.

Type: fix

Test Plan

Open the sticker picker and click on the area where there is both a sticker and the underlying layer (i.e. the timeline) has a sender username. Verify that the sticker is sent and the user mention is not in the send message box.

Diff Detail

Repository
rK kazv
Branch
tusooa/stacked
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 45
Build 79: GitLab CI for kazv
Build 78: arc lint + arc unit

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.May 19 2024, 11:13 AM
Harbormaster failed remote builds in B45: Diff 76!
This revision is now accepted and ready to land.May 29 2024, 5:46 AM