Page MenuHomePhorge
Differential D232

Let Filehandler react to eventContent modification
Needs RevisionPublic
Actions

Authored by nannanko on Thu, Sep 18, 6:32 AM.

Details

Reviewers
tusooa
Group Reviewers
O1: the Kazv Project
Maniphest Tasks
T152: FileHandler is not reactive against change in the mxc uri
Summary

Now FileHandler.qml can react to eventContent modification.

Type: fix

Test Plan

Varify unit tests pass.

Diff Detail

Repository
rK kazv
Branch
nannanko/filehandler-eventcontent-change
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 429
Build 841: GitLab CI for kazv
Build 840: arc lint + arc unit

Event Timeline

nannanko created this revision.Thu, Sep 18, 6:32 AM
Owners added a reviewer: O1: the Kazv Project.Thu, Sep 18, 6:32 AM
Herald added a reviewer: servant. · View Herald TranscriptThu, Sep 18, 6:32 AM

Please add a changelog type to the summary, using the following format:

Type: (add|remove|skip|security|fix)

nannanko edited the summary of this revision. (Show Details)Thu, Sep 18, 6:32 AM
nannanko removed a reviewer: servant.
nannanko added a task: T152: FileHandler is not reactive against change in the mxc uri.Thu, Sep 18, 6:35 AM
Harbormaster completed remote builds in B428: Diff 681.Thu, Sep 18, 6:45 AM
nannanko requested review of this revision.Thu, Sep 18, 6:45 AM
nannanko updated this revision to Diff 682.Thu, Sep 18, 4:23 PM

Delete useless code.

Harbormaster completed remote builds in B429: Diff 682.Thu, Sep 18, 4:37 PM
nannanko mentioned this in T152: FileHandler is not reactive against change in the mxc uri.Thu, Sep 18, 11:46 PM
tusooa added a comment.Sat, Sep 20, 7:19 PM

mxcUri, sha256, key, iv can be combined into one object.

properties can be turned into a helper function that returns the object.

nannanko updated this revision to Diff 687.Mon, Sep 22, 6:55 AM

Use helper function instead of useless properties

Harbormaster completed remote builds in B434: Diff 687.Mon, Sep 22, 7:08 AM
tusooa requested changes to this revision.Sat, Sep 27, 6:58 PM
tusooa added inline comments.
src/contents/ui/FileHandler.qml
94
181–184

mediaId property has been removed, I don't think it can still be accessed

This revision now requires changes to proceed.Sat, Sep 27, 6:58 PM
tusooa retitled this revision from Let Filehandler react to eventCnotent modification to Let Filehandler react to eventContent modification.Sat, Oct 4, 7:02 PM

Revision Contents
Changeset List

PathSizePackages
src/
contents/
ui/
180 linesO1: the Kazv Project
tests/
quick-tests/
240 linesO1: the Kazv Project

Diff 682

View Options

src/contents/ui/FileHandler.qml

Loading...
View Options

src/tests/quick-tests/tst_FileHandler.qml

Loading...